Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753874AbcDKOxR (ORCPT ); Mon, 11 Apr 2016 10:53:17 -0400 Received: from mail-pf0-f180.google.com ([209.85.192.180]:36455 "EHLO mail-pf0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752873AbcDKOxO (ORCPT ); Mon, 11 Apr 2016 10:53:14 -0400 Subject: Re: [PATCH v2 07/11] serial: 8250: enable AFE on ports where FIFO is 16 bytes To: Andy Shevchenko References: <1460379071-132591-1-git-send-email-andriy.shevchenko@linux.intel.com> <1460379071-132591-8-git-send-email-andriy.shevchenko@linux.intel.com> Cc: "Bryan O'Donoghue" , linux-serial@vger.kernel.org, Vinod Koul , linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, Greg Kroah-Hartman , ismo.puustinen@intel.com, Heikki Krogerus From: Peter Hurley Message-ID: <570BBA53.4080508@hurleysoftware.com> Date: Mon, 11 Apr 2016 07:53:07 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1460379071-132591-8-git-send-email-andriy.shevchenko@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 583 Lines: 12 On 04/11/2016 05:51 AM, Andy Shevchenko wrote: > Intel Quark has 16550A compatible UART with autoflow feature enabled. It has > only 16 bytes of FIFO. Currently serial8250_do_set_termios() prevents to enable > autoflow since the minimum requirement of 32 bytes of FIFO size. > > Drop a FIFO size limitation to allow autoflow control be enabled on such UARTs. > > While here, comment out UART_CAP_AFE for PORT_AR7 since it wasn't working and > it will be not a good idea to use it in conjunction with trigger level of 1 > byte. Reviewed-by: Peter Hurley