Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755617AbcDKPe4 (ORCPT ); Mon, 11 Apr 2016 11:34:56 -0400 Received: from mail-wm0-f41.google.com ([74.125.82.41]:33997 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755553AbcDKPd3 (ORCPT ); Mon, 11 Apr 2016 11:33:29 -0400 Message-ID: <1460388795.19152.38.camel@nexus-software.ie> Subject: Re: [PATCH v1 12/12] serial: 8250_lpss: enable DMA on Intel Quark UART From: "Bryan O'Donoghue" To: Andy Shevchenko , Vinod Koul , linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, Greg Kroah-Hartman , ismo.puustinen@intel.com, Heikki Krogerus , linux-serial@vger.kernel.org Date: Mon, 11 Apr 2016 16:33:15 +0100 In-Reply-To: <1460061433-63750-13-git-send-email-andriy.shevchenko@linux.intel.com> References: <1460061433-63750-1-git-send-email-andriy.shevchenko@linux.intel.com> <1460061433-63750-13-git-send-email-andriy.shevchenko@linux.intel.com> Organization: Nexus Software Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5-1ubuntu3.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 360 Lines: 13 On Thu, 2016-04-07 at 23:37 +0300, Andy Shevchenko wrote: Preface. I tried this on Galileo and it appears to work. I'll do some throughput testing to verify but, initially the results are positive :) > + lpss->dma_maxburst = 8; Are these dwords ? If those are bytes then the maxburst value looks small. In the BSP the max burst is 32 bytes. --- bod