Date: Mon, 11 Apr 2016 16:44:36 +0100
From: Peter Griffin <peter.griffin@linaro.org>
To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        mathias.nyman@intel.com, gregkh@linuxfoundation.org
Cc: lee.jones@linaro.org, balbi@kernel.org, linux-usb@vger.kernel.org,
        maxime.coquelin@st.com, patrice.chotard@st.com, stable@vger.kernel.org,
        gregory.clement@free-electrons.com, yoshihiro.shimoda.uh@renesas.com
Subject: Re: [PATCH] usb: host: xhci-plat: Make enum xhci_plat_type start at
 a non zero value
Message-ID: <20160411154436.GA14580@griffinp-ThinkPad-X1-Carbon-2nd>
References: <1458917188-28452-1-git-send-email-peter.griffin@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1458917188-28452-1-git-send-email-peter.griffin@linaro.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 888
Lines: 28

Hi Mathias,

On Fri, 25 Mar 2016, Peter Griffin wrote:

> Otherwise generic-xhci and xhci-platform which have no data get wrongly
> detected as XHCI_PLAT_TYPE_MARVELL_ARMADA by xhci_plat_type_is().
> 
> This fixes a regression in v4.5 for STiH407 family SoC's which use the
> synopsis dwc3 IP, whereby the disable_clk error path gets taken due to
> wrongly being detected as XHCI_PLAT_TYPE_MARVELL_ARMADA and the hcd never
> gets added.
> 
> I suspect this will also fix other dwc3 DT platforms such as Exynos,
> although I've only tested on STih410 SoC.
> 
> Fixes: 4efb2f694114 ("usb: host: xhci-plat: add struct xhci_plat_priv")

Can you take this 1 charcter fix for the next -rc?

It fixes a regression introduced in commit 4efb2f694114 for usb3 for some
DT platforms.

Then Felipes series which re-works this code will hopefully be merged in the
next merge window.

regards,

Peter.