Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755374AbcDKPuX (ORCPT ); Mon, 11 Apr 2016 11:50:23 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:60496 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754233AbcDKPuV (ORCPT ); Mon, 11 Apr 2016 11:50:21 -0400 Date: Mon, 11 Apr 2016 16:50:10 +0100 From: Mark Brown To: Thierry Reding Cc: Javier Martinez Canillas , Jon Hunter , Liam Girdwood , linux-kernel@vger.kernel.org, Bjorn Andersson Message-ID: <20160411155010.GK3351@sirena.org.uk> References: <1460038959-21592-1-git-send-email-thierry.reding@gmail.com> <570B8376.6030505@nvidia.com> <20160411114612.GD17743@ulmo.ba.sec> <20160411125814.GE3351@sirena.org.uk> <20160411130914.GA16994@ulmo.ba.sec> <570BAA68.2000701@osg.samsung.com> <20160411135715.GG3351@sirena.org.uk> <20160411140730.GA27400@ulmo.ba.sec> <20160411143239.GJ3351@sirena.org.uk> <20160411144902.GC27400@ulmo.ba.sec> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="wIc/V6YLA2QdyfT4" Content-Disposition: inline In-Reply-To: <20160411144902.GC27400@ulmo.ba.sec> X-Cookie: I invented skydiving in 1989! User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 1/5] regulator: core: Resolve supply earlier X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2241 Lines: 49 --wIc/V6YLA2QdyfT4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 11, 2016 at 04:49:02PM +0200, Thierry Reding wrote: > On Mon, Apr 11, 2016 at 03:32:39PM +0100, Mark Brown wrote: > > Long term we want a bigger refactoring but > > I think we need to sort out what's going on with probe ordering in > > general before we do that, that's part of the problem here - people > > really aren't happy with deferral and for good reason. > What happened to correctness first? I thought we had at some point all > agreed that even if deferred probe wasn't perfect it would at least give > us correct results. And if all the code in place to properly establish > the dependencies we could rid ourselves of all the downsides at once if > ever we came up with a better alternative. This has never been completely correct since it predates deferred probe in the first place and was originally relying on init ordering. Trying to use deferred probe unconditionally right now would mean rewriting the registration section of almost every regulator driver which seems a bigger and more error prone process better approached after the current issues are resolved. Without doing that it'd just be shuffling the problem around again and I'm not convinced it's a good idea to rush such a large change. If we just defer in the cases where we have identified a need to defer that takes a lot of the pressure off and reduces the risks, a big part of why this is coming up is that we made a change that affects all drivers so it seems better not to continue making such broad changes in a hurry. =20 --wIc/V6YLA2QdyfT4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXC8exAAoJECTWi3JdVIfQd8QH/jEEwZqK5hUXj4wjFITpnk3I KRcMk+rJWNHCNkmVHHigKgk06hi2cgk8BR21WNY0JuKPEPNSyu6y6LvXgFLeEBQr 7kRsSMUT3OVYIJtZ5sUZeLuL+CflkGVuNXJkV6tif7KFwTsQmkaXL3nWpqbOSvkP yYXM+7wujWr7KdEeJp2oUhP+xIwdlFohwVrdHTBt8A+2vDqAvVkMgMLcVlP6PxUU 3oHTqc8B6j9UMo6NniD008NcQDXaCEaFA+7V3QxsKm+sEVWWsgZmaadLuGFkrZ/8 uatDSsQTBOJg4zVaVyjJ75S2fA47OeOcnrfh2Mr+4CZY/DVY2KVikWJFNGDKDso= =U4yP -----END PGP SIGNATURE----- --wIc/V6YLA2QdyfT4--