Message-ID: <570BCC51.50004@gmail.com>
Date: Mon, 11 Apr 2016 21:39:53 +0530
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: Mike Snitzer <snitzer@redhat.com>
CC: Alasdair Kergon <agk@redhat.com>, Shaohua Li <shli@kernel.org>,
        linux-kernel@vger.kernel.org, dm-devel@redhat.com,
        linux-raid@vger.kernel.org
Subject: Re: dm: ioctl: use kvfree
References: <1460387677-19948-1-git-send-email-sudipm.mukherjee@gmail.com> <20160411151714.GB25938@redhat.com>
In-Reply-To: <20160411151714.GB25938@redhat.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 786
Lines: 21

On Monday 11 April 2016 08:47 PM, Mike Snitzer wrote:
> On Mon, Apr 11 2016 at 11:14am -0400,
> Sudip Mukherjee <sudipm.mukherjee@gmail.com> wrote:
>
>> We can use kvfree() instead of calling kfree() and vfree() based on
>> if-else and param_flags. kvfree() will check the type of address and
>> will call the respective function to free it.
>> Additionally we can also remove the use of DM_PARAMS_KMALLOC and
>> DM_PARAMS_VMALLOC.
>>
>> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
>
> Have you actually tested htis?  Last time I looked to do this it exposed
> crashes.  I don't have time to dig into this again right now but this is
> _not_ as simple as this patch implies.
>

No, it was just build tested. Is it possible to test it in qemu or kvm?

regards
sudip