Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754362AbcDKRlc (ORCPT ); Mon, 11 Apr 2016 13:41:32 -0400 Received: from mail-lf0-f49.google.com ([209.85.215.49]:33351 "EHLO mail-lf0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751216AbcDKRla (ORCPT ); Mon, 11 Apr 2016 13:41:30 -0400 Subject: Re: [PATCH RFT 2/2] macb: kill PHY reset code To: Andrew Lunn References: <81129033.NXiOLTg1so@wasted.cogentembedded.com> <2811962.eGX2i5RJbZ@wasted.cogentembedded.com> <20160411022802.GB4307@lunn.ch> Cc: nicolas.ferre@atmel.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: <570BE1C5.70502@cogentembedded.com> Date: Mon, 11 Apr 2016 20:41:25 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160411022802.GB4307@lunn.ch> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1650 Lines: 50 Hello. On 04/11/2016 05:28 AM, Andrew Lunn wrote: >> With the 'phylib' now being aware of the "reset-gpios" PHY node property, >> there should be no need to frob the PHY reset in this driver anymore... >> >> Signed-off-by: Sergei Shtylyov >> >> --- >> drivers/net/ethernet/cadence/macb.c | 17 ----------------- >> drivers/net/ethernet/cadence/macb.h | 1 - >> 2 files changed, 18 deletions(-) >> >> Index: net-next/drivers/net/ethernet/cadence/macb.c >> =================================================================== >> --- net-next.orig/drivers/net/ethernet/cadence/macb.c >> +++ net-next/drivers/net/ethernet/cadence/macb.c [...] >> @@ -2977,18 +2976,6 @@ static int macb_probe(struct platform_de >> else >> macb_get_hwaddr(bp); >> >> - /* Power up the PHY if there is a GPIO reset */ >> - phy_node = of_get_next_available_child(np, NULL); >> - if (phy_node) { >> - int gpio = of_get_named_gpio(phy_node, "reset-gpios", 0); >> - >> - if (gpio_is_valid(gpio)) { >> - bp->reset_gpio = gpio_to_desc(gpio); >> - gpiod_direction_output(bp->reset_gpio, 1); > > Hi Sergei > > The code you are deleting would of ignored the flags in the gpio > property, i.e. active low. Hm, you're right -- I forgot about that... :-/ > The new code in the previous patch does > however take the flags into account. Did you check if there are any > device trees which have flags, which were never used, but are now > going to be used and thus break... Checked this now and found out arch/arm/boot/dts/ar91-vinco.dts. Looks like it needs to be fixed indeed... > Andrew MBR, Sergei