Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753919AbcDKRxX (ORCPT ); Mon, 11 Apr 2016 13:53:23 -0400 Received: from mail-yw0-f171.google.com ([209.85.161.171]:34059 "EHLO mail-yw0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751216AbcDKRxV (ORCPT ); Mon, 11 Apr 2016 13:53:21 -0400 MIME-Version: 1.0 In-Reply-To: <570BC024.1070504@axis.com> References: <1460355869-13539-1-git-send-email-larper@axis.com> <1460380981.6473.544.camel@edumazet-glaptop3.roam.corp.google.com> <570BA8C7.1000905@axis.com> <1460384551.6473.551.camel@edumazet-glaptop3.roam.corp.google.com> <570BC024.1070504@axis.com> From: Cong Wang Date: Mon, 11 Apr 2016 10:53:01 -0700 Message-ID: Subject: Re: [PATCH net v2] net: sched: do not requeue a NULL skb To: Lars Persson Cc: Eric Dumazet , Lars Persson , Linux Kernel Network Developers , Jamal Hadi Salim , LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 929 Lines: 26 On Mon, Apr 11, 2016 at 8:17 AM, Lars Persson wrote: > > > On 04/11/2016 04:22 PM, Eric Dumazet wrote: >> >> On Mon, 2016-04-11 at 15:38 +0200, Lars Persson wrote: >> >>> I though it would be prudent because the queue can be non-empty even for >>> the case of skb=NULL. So should it be there in this patch, another patch >>> or not at all ? >> >> >> Then maybe change return code ? >> >> It seems strange that a validate_xmit_skb_list() failure stops the >> __qdisc_run() loop but schedules another round. >> >> > > It was suggested by Cong Wang to return 0 in order to stop the loop. Do you > guys agree that the loop should be stopped for such failures ? Then I will > put the schedule call inside the if as you proposed earlier. I don't see any reason why we should continue on failure. And, I didn't suggest you to return reschedule it either. I was suggesting to just return 0 for skb == NULL case.