Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755533AbcDKTBm (ORCPT ); Mon, 11 Apr 2016 15:01:42 -0400 Received: from mail-lf0-f51.google.com ([209.85.215.51]:36773 "EHLO mail-lf0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755310AbcDKTBZ (ORCPT ); Mon, 11 Apr 2016 15:01:25 -0400 Subject: Re: [PATCH RFT 2/2] macb: kill PHY reset code To: Andrew Lunn References: <81129033.NXiOLTg1so@wasted.cogentembedded.com> <2811962.eGX2i5RJbZ@wasted.cogentembedded.com> <20160411022802.GB4307@lunn.ch> <570BE1C5.70502@cogentembedded.com> <20160411181904.GB29709@lunn.ch> <570BEF46.7060105@cogentembedded.com> <20160411185115.GA30623@lunn.ch> Cc: nicolas.ferre@atmel.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: <570BF481.9070903@cogentembedded.com> Date: Mon, 11 Apr 2016 22:01:21 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160411185115.GA30623@lunn.ch> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1195 Lines: 37 On 04/11/2016 09:51 PM, Andrew Lunn wrote: >>>>> The code you are deleting would of ignored the flags in the gpio >>>>> property, i.e. active low. >>>> >>>> Hm, you're right -- I forgot about that... :-/ >>>> >>>>> The new code in the previous patch does >>>>> however take the flags into account. Did you check if there are any >>>>> device trees which have flags, which were never used, but are now >>>>> going to be used and thus break... >>>> >>>> Checked this now and found out arch/arm/boot/dts/ar91-vinco.dts. >>>> Looks like it needs to be fixed indeed... >>>> >>> And this is where it gets tricky. You are breaking backwards >>> compatibility by now respecting the flag. An old DT blob is not going >>> to work. >> >> Do we care that much about the DT blobs that are just *wrong*? > > Wrong, but currently works. Note that it's not only using GPIO_ACTIVE_HIGH but does that against what the MACB binding documents. >>> You potentially need to add a new property and deprecate the old one. >> >> I would like to avoid that... > > You will need the agreement from the at91-vinco maintainer. I'll try submitting a formal DT patch... > Andrew MBR, Sergei