Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755340AbcDKT2j (ORCPT ); Mon, 11 Apr 2016 15:28:39 -0400 Received: from mail-pa0-f44.google.com ([209.85.220.44]:33436 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755217AbcDKT2h (ORCPT ); Mon, 11 Apr 2016 15:28:37 -0400 Subject: Re: [PATCH 1/2] sched/fair: move cpufreq hook to update_cfs_rq_load_avg() To: "Rafael J. Wysocki" References: <1458606068-7476-1-git-send-email-smuckle@linaro.org> <56F91D56.4020007@arm.com> <56F95D10.4070400@linaro.org> <56F97856.4040804@arm.com> <56F98832.3030207@linaro.org> <20160330193544.GD407@worktop> <56FC807C.80204@linaro.org> <20160331073743.GF3408@twins.programming.kicks-ass.net> <56FD95EE.6090007@linaro.org> <20160401092019.GN3430@twins.programming.kicks-ass.net> Cc: Peter Zijlstra , Dietmar Eggemann , Ingo Molnar , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Vincent Guittot , Morten Rasmussen , Juri Lelli , Patrick Bellasi , Michael Turquette From: Steve Muckle X-Enigmail-Draft-Status: N1110 Message-ID: <570BFAE2.4080301@linaro.org> Date: Mon, 11 Apr 2016 12:28:34 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160401092019.GN3430@twins.programming.kicks-ass.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 904 Lines: 27 Hi Rafael, On 04/01/2016 02:20 AM, Peter Zijlstra wrote: >> > My thinking was in CFS we get rid of the (cpu == smp_processor_id()) >> > condition for calling the cpufreq hook. >> > >> > The sched governor can then calculate utilization and frequency required >> > for cpu. If (cpu == smp_processor_id()), the update is processed >> > normally. If (cpu != smp_processor_id()) and the new frequency is higher >> > than cpu's Fcur, the sched gov IPIs cpu to continue running the update >> > operation. Otherwise, the update is dropped. >> > >> > Does that sound plausible? > > Can be done I suppose.. Currently we drop schedutil updates for a target CPU which do not occur on that CPU. Is this solely due to platforms which must run the cpufreq driver on the target CPU? Are there also shared cpufreq policies where the driver needs to run on any CPU in the affected policy/freq domain? thanks, Steve