Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755436AbcDKWDZ (ORCPT ); Mon, 11 Apr 2016 18:03:25 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:49051 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752191AbcDKWDX (ORCPT ); Mon, 11 Apr 2016 18:03:23 -0400 Date: Mon, 11 Apr 2016 15:03:20 -0700 From: "sboyd@codeaurora.org" To: Alexey Brodkin Cc: Jose Abreu , "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , "mturquette@baylibre.com" , Carlos Palminha , "devicetree@vger.kernel.org" , "linux-snps-arc@lists.infradead.org" , Vineet Gupta , "linux-clk@vger.kernel.org" Subject: Re: [RESEND PATCH v4] clk/axs10x: Add I2S PLL clock driver Message-ID: <20160411220320.GB14441@codeaurora.org> References: <50c75be8ecab225a1dd49628a173d211a02755b2.1459791946.git.joabreu@synopsys.com> <1460393270.5119.20.camel@synopsys.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1460393270.5119.20.camel@synopsys.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 901 Lines: 27 On 04/11, Alexey Brodkin wrote: > On Mon, 2016-04-11 at 11:41 +0100, Jose Abreu wrote: > > + * warranty of any kind, whether express or implied. > > + */ > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > "linux/platform_device.h" includes "linux/device.h" so you may make this list of headers > a little bit shorter. > > > +#include > > +#include > > +#include > > "linux/of_address.h" already includes "linux/of.h". It's ok to include things twice. In fact, its better to avoid any implicit includes so that if we ever want to remove includes from other headers we can do so without disturbing this driver. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project