Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755521AbcDKXg3 (ORCPT ); Mon, 11 Apr 2016 19:36:29 -0400 Received: from mail-pf0-f174.google.com ([209.85.192.174]:36757 "EHLO mail-pf0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755434AbcDKXgX (ORCPT ); Mon, 11 Apr 2016 19:36:23 -0400 From: Andrey Vagin To: linux-kernel@vger.kernel.org Cc: Andrey Vagin , Oleg Nesterov , Andrew Morton , Cyrill Gorcunov , Pavel Emelyanov , Roger Luethi , Arnd Bergmann , Arnaldo Carvalho de Melo , David Ahern , Andy Lutomirski , Pavel Odintsov Subject: [PATCH 08/15] task_diag: Only add VMAs for thread_group leader Date: Mon, 11 Apr 2016 16:35:48 -0700 Message-Id: <1460417755-18201-9-git-send-email-avagin@openvz.org> X-Mailer: git-send-email 2.5.5 In-Reply-To: <1460417755-18201-1-git-send-email-avagin@openvz.org> References: <1460417755-18201-1-git-send-email-avagin@openvz.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1072 Lines: 36 From: David Ahern threads of a process share the same VMAs, so when dumping all threads for all processes only push vma data for group leader. Signed-off-by: David Ahern Signed-off-by: Andrey Vagin --- fs/proc/task_diag.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/fs/proc/task_diag.c b/fs/proc/task_diag.c index e0f0b03..00db32d 100644 --- a/fs/proc/task_diag.c +++ b/fs/proc/task_diag.c @@ -433,7 +433,17 @@ static int task_diag_fill(struct task_struct *tsk, struct sk_buff *skb, } if (show_flags & TASK_DIAG_SHOW_VMA) { - if (i >= n) + bool dump_vma = true; + + /* if the request is to dump all threads of all processes + * only show VMAs for group leader. + */ + if ((req->dump_strategy == TASK_DIAG_DUMP_ALL_THREAD || + req->dump_strategy == TASK_DIAG_DUMP_THREAD) && + !thread_group_leader(tsk)) + dump_vma = false; + + if (dump_vma && i >= n) err = fill_vma(tsk, skb, cb, &progress, show_flags); if (err) goto err; -- 2.5.5