Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755399AbcDKXp2 (ORCPT ); Mon, 11 Apr 2016 19:45:28 -0400 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:50097 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753237AbcDKXp0 (ORCPT ); Mon, 11 Apr 2016 19:45:26 -0400 Message-ID: <1460418313.25201.69.camel@decadent.org.uk> Subject: Re: [PATCH 4.5 026/238] PCI: Disable IO/MEM decoding for devices with non-compliant BARs From: Ben Hutchings To: Greg Kroah-Hartman , linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org, Bjorn Helgaas , Andi Kleen Date: Tue, 12 Apr 2016 00:45:13 +0100 In-Reply-To: <20160410183457.730080842@linuxfoundation.org> References: <20160410183456.398741366@linuxfoundation.org> <20160410183457.730080842@linuxfoundation.org> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-4Fs9v9Ki24yDn3ZSEC4c" X-Mailer: Evolution 3.18.5.1-1 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 2a02:8011:400e:2:6f00:88c8:c921:d332 X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2324 Lines: 63 --=-4Fs9v9Ki24yDn3ZSEC4c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, 2016-04-10 at 11:33 -0700, Greg Kroah-Hartman wrote: > 4.5-stable review patch.=C2=A0=C2=A0If anyone has any objections, please = let me know. >=20 > ------------------ >=20 > From: Bjorn Helgaas >=20 > commit b84106b4e2290c081cdab521fa832596cdfea246 upstream. >=20 > The PCI config header (first 64 bytes of each device's config space) is > defined by the PCI spec so generic software can identify the device and > manage its usage of I/O, memory, and IRQ resources. >=20 > Some non-spec-compliant devices put registers other than BARs where the > BARs should be.=C2=A0=C2=A0When the PCI core sizes these "BARs", the read= s and writes > it does may have unwanted side effects, and the "BAR" may appear to > describe non-sensical address space. >=20 > Add a flag bit to mark non-compliant devices so we don't touch their BARs= . > Turn off IO/MEM decoding to prevent the devices from consuming address > space, since we can't read the BARs to find out what that address space > would be. [...] No objection, but patch 005/238 seems to depend on this so please reorder them so bisection will work. Ben. --=20 Ben Hutchings This sentence contradicts itself - no actually it doesn't. --=-4Fs9v9Ki24yDn3ZSEC4c Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCgAGBQJXDDcJAAoJEOe/yOyVhhEJou0P/ig8jmgS/4mxkl0qEsGD1tB5 gEyh4//PeF/Bk7KXgiw7Qr4qc886oS5ZGc6ot5ycM7EDlRaNfY5zY1SZx+h90Qx2 Ooia6M1RZdhi0YbR4SERVgVxSjcwJow0rqb5Zy4w9BTmEMFu2m0MWXuz2RQ1Fikq d6OiFFp5v/yIoeDjh3exsCOwbQy7UltLn6jVepuc7SezJHLSYt/4+vrMmINGI0vq eq6ne+bbtCWr93bU5wbbVVhIjKM0njB0xAsx8zrxSOh31pWXYfC74ScKJY0LLAU9 XdFkcT/ZTd+wOXdQOqxt3LEmLqqn0I0oMrAr29d1N+9Yp1Avj3YJutQ7umsIcW1m 3mgKj7MtrVVBH5C0+eov3Z/nA62eL2xVrrs6JnVjfY1gvZbh4eFcVWYj8t94pzfE 2EjRPV5jqP6MdI5tcpaTnBI58os17ylXHGYrJWVoy2MaeR5ayEuSSvH5G4U0pfaT PHjuWVlhlesN/d6aWdSuYFt4tAOBh1IbNjukLxWK8gPmzqfXsRE+X9odFZUKygBd j+Uf4Rz7PyvWO9zwOR2zpjWHXZoMDcWIbgSJ5CkepoAIimLiCu8huZTDTya2RetD f8aoly0T+A79vbEbG24Mhf5bducfe07bpoZyYnm5+udLGGVb1Db4dKRS1yPNKhAt gG9Kh6gbfwfKGTaOi8Hu =Khw/ -----END PGP SIGNATURE----- --=-4Fs9v9Ki24yDn3ZSEC4c--