Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755173AbcDLA3W (ORCPT ); Mon, 11 Apr 2016 20:29:22 -0400 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:50313 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753521AbcDLA3V (ORCPT ); Mon, 11 Apr 2016 20:29:21 -0400 Message-ID: <1460420943.25201.71.camel@decadent.org.uk> Subject: Re: [PATCH 4.5 036/238] aacraid: Set correct msix count for EEH recovery From: Ben Hutchings To: Raghava Aditya Renukunta Cc: stable@vger.kernel.org, Shane Seymour , Johannes Thumshirn , "Martin K. Petersen" , Greg Kroah-Hartman , LKML Date: Tue, 12 Apr 2016 01:29:03 +0100 In-Reply-To: <20160410183458.424247219@linuxfoundation.org> References: <20160410183456.398741366@linuxfoundation.org> <20160410183458.424247219@linuxfoundation.org> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-VZPD9pr7smneiCFfm1Qu" X-Mailer: Evolution 3.18.5.1-1 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 2a02:8011:400e:2:6f00:88c8:c921:d332 X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2756 Lines: 80 --=-VZPD9pr7smneiCFfm1Qu Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, 2016-04-10 at 11:33 -0700, Greg Kroah-Hartman wrote: > 4.5-stable review patch.=C2=A0=C2=A0If anyone has any objections, please = let me know. >=20 > ------------------ >=20 > From: Raghava Aditya Renukunta >=20 > commit ecc479e00db8eb110b200afe1effcb3df20ca7ae upstream. >=20 > During EEH recovery number of online CPU's might change thereby changing > the number of MSIx vectors. Since each fib is allocated to a vector, > changes in the number of vectors causes fib to be sent thru invalid > vectors.In addition the correct number of MSIx vectors is not updated in > the INIT struct sent to the controller, when it is reinitialized. >=20 > Fixed by reassigning vectors to fibs based on the updated number of MSIx > vectors and updating the INIT structure before sending to controller. Really? [...] > --- a/drivers/scsi/aacraid/linit.c > +++ b/drivers/scsi/aacraid/linit.c > @@ -1404,8 +1404,18 @@ static int aac_acquire_resources(struct > =C2=A0 > =C2=A0 aac_adapter_enable_int(dev); > =C2=A0 > - if (!dev->sync_mode) > + /*max msix may change=C2=A0=C2=A0after EEH > + =C2=A0* Re-assign vectors to fibs > + =C2=A0*/ > + aac_fib_vector_assign(dev); > + > + if (!dev->sync_mode) { > + /* After EEH recovery or suspend resume, max_msix count > + =C2=A0* may change, therfore updating in init as well. > + =C2=A0*/ > =C2=A0 aac_adapter_start(dev); > + dev->init->Sa_MSIXVectors =3D cpu_to_le32(dev->max_msix); Aren't these two lines in the wrong order? Ben. > + } > =C2=A0 return 0; > =C2=A0 > =C2=A0error_iounmap: --=20 Ben Hutchings This sentence contradicts itself - no actually it doesn't. --=-VZPD9pr7smneiCFfm1Qu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCgAGBQJXDEFPAAoJEOe/yOyVhhEJXucP/0XbKbi7GU6w8q2lxubZXz+E uiAulGjiBoegqtBOCSfcVV16ETcQF4bNXdqbmpPwF4dN1Jk7zNnN8QHFKASMzTB3 7jDJZBi2sWAT62fZ76ykvcujuGZsZc8/8Yr+WebvwqJdHWddhxZQvV+NHADvXXKW KOWApKGESlz0qLgP/zFkDIiNEF2W1OOls+wDvQvVEvL3YP5gjruDIjUDSeNJ7pBl UFRGfpPwVMXbRv6FKxeKj8YnNKEe/8eX48BOYhX1fWDx4JMzMBw6FRg7pyLV2QEt MhZcaz+3gh6C+zgVFdSUwfuUfnzBvtF1y/oJCiI1Uu45ytrsGpAZ4qatpXz5tIFf mIVMbujo8Hiu+Mj4EeoJtkO96u+doYQsqRJAcU2fc7WHw/if9qtT1epYFXUDynn0 aupFc2ruTJiQ7eZjnaWoXAnTbwyG/itydplwLZYfe9ZeofZeRnmJkdVWJ2YsAexv DX+YnZkVvMEnVujuu+6hB5Yl1hjXfG39sRBZgsh6okRaIn5ZQsFA/3fMRHWR6oDv v0LFFm8Z/VtFHeI7UjNYP0NDHJiVhHRvV0282R8i0wZdeOCfaWQ1FOr74cWQnkXE 7RcYiCl+b78VSLlJA/JHiSoP7Yxuh0IUW+reXH16GE2zOxNfsZONaLldyKBBYJeX GKHHkYtQX7RsVoDJpg0i =KG7Q -----END PGP SIGNATURE----- --=-VZPD9pr7smneiCFfm1Qu--