Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755604AbcDLCtl (ORCPT ); Mon, 11 Apr 2016 22:49:41 -0400 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:50953 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753515AbcDLCtj (ORCPT ); Mon, 11 Apr 2016 22:49:39 -0400 Message-ID: <1460429373.25201.103.camel@decadent.org.uk> Subject: Re: [PATCH 4.5 113/238] mtip32xx: Implement timeout handler From: Ben Hutchings To: Selvan Mani , Rajesh Kumar Sambandam , Asai Thambi S P Cc: stable@vger.kernel.org, Jens Axboe , Greg Kroah-Hartman , LKML Date: Tue, 12 Apr 2016 03:49:33 +0100 In-Reply-To: <20160410183502.720619177@linuxfoundation.org> References: <20160410183456.398741366@linuxfoundation.org> <20160410183502.720619177@linuxfoundation.org> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-vTFlyoQ5uG0yLtmHFKzs" X-Mailer: Evolution 3.18.5.1-1 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 2a02:8011:400e:2:6f00:88c8:c921:d332 X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2359 Lines: 64 --=-vTFlyoQ5uG0yLtmHFKzs Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, 2016-04-10 at 11:34 -0700, Greg Kroah-Hartman wrote: > 4.5-stable review patch.=C2=A0=C2=A0If anyone has any objections, please = let me know. >=20 > ------------------ >=20 > From: Asai Thambi SP >=20 > commit abb0ccd185c9e31847709b86192e6c815d1f57ad upstream. >=20 > Added timeout handler. Replaced blk_mq_end_request() with > blk_mq_complete_request() to avoid double completion of a request. >=20 > Signed-off-by: Selvan Mani > Signed-off-by: Rajesh Kumar Sambandam > Signed-off-by: Asai Thambi S P > Signed-off-by: Jens Axboe > Signed-off-by: Greg Kroah-Hartman >=20 > --- > =C2=A0drivers/block/mtip32xx/mtip32xx.c |=C2=A0=C2=A0=C2=A095 +++++++++++= +++++++++++++++++++++++---- > =C2=A0drivers/block/mtip32xx/mtip32xx.h |=C2=A0=C2=A0=C2=A0=C2=A07 ++ > =C2=A02 files changed, 92 insertions(+), 10 deletions(-) [...] This is >100 lines (the rough limit for stable), and it's part of a whole series of complex and inadequately explained changes. How thoroughly have these changes been tested against 4.4 and 4.5? Ben. --=20 Ben Hutchings This sentence contradicts itself - no actually it doesn't. --=-vTFlyoQ5uG0yLtmHFKzs Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCgAGBQJXDGI9AAoJEOe/yOyVhhEJrvEQALsQg1MzzcDI7KuSJU/n0WkL 6xx50S2l+75ckR9UBUomzGiNmwQG/xnKKRzBS3H1CV1jHIDJBOuGmz/HclyPtvOd ceCVkJxMz1Va5McdISO8OwpXZgOmwpjINxDGQ3LYIAbAt139rEuLkJ/uRDq9QEI0 Q99KpD46UQS4VgSueQL/UPPOB86Rprz3UYY5BVcI7QUvqkTrLJqy31/PyiJ58SsM UKfLImG0TVaihYv96LNrWkSgyOMUFplKKGxScoRDSrc1s7Wz5VIOmtPyXGH/0Woi cTEwAIXWkFFR5D4Eu+FpNXnI9Om7S56X25hjOp2F18QKU79OU6dqKV+fOJ0IIJ0U fgL0N7SJZvYU1mBaN5ua/q99PfA/r0DmkkNfKDIzwWQMYYL7fYcrnURmjmc8+YoU hBGfezViLjBzCQf+Fd2TXA51To0+J45iDU5KW0p4aSc0Wrf1t1mQSaJFrMM8/jfg 53c+jXfX5ZxjvScieMRe48XwyBucnRM4ZVuv74ZlnLB/PTjHalO6BFn5DxLBUyfm 9ssKhkBqlOGSP3Dc/9hwCSsSV2+GWGmySvfgrhUtskEFU0C3l2wKZH6ThCionVmK /DwF3jGJl6mM6nwP96uKmBhwmjvXIG9YG7kBdOtKiAs2oa3sI5xMoNFCt6wtsbrO abDpCaGQlew+N1VnBgXX =6FPl -----END PGP SIGNATURE----- --=-vTFlyoQ5uG0yLtmHFKzs--