Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754159AbcDLGKv (ORCPT ); Tue, 12 Apr 2016 02:10:51 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:34068 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750795AbcDLGKt (ORCPT ); Tue, 12 Apr 2016 02:10:49 -0400 Date: Tue, 12 Apr 2016 07:10:07 +0100 From: Mark Brown To: P L Sai Krishna Cc: Michal Simek , Soren Brinkmann , David Woodhouse , Brian Norris , Javier Martinez Canillas , Boris Brezillon , Stephen Warren , Geert Uytterhoeven , "Andrew F. Davis" , Marek Vasut , Jagan Teki , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Harini Katakam , Punnaiah Choudary Kalluri , Anirudha Sarangi , P L Sai Krishna Message-ID: <20160412061007.GY3351@sirena.org.uk> References: <1460039969-9835-1-git-send-email-lakshmis@xilinx.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3C3ZMpwu25Mtx3MN" Content-Disposition: inline In-Reply-To: <1460039969-9835-1-git-send-email-lakshmis@xilinx.com> X-Cookie: I invented skydiving in 1989! User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [LINUX PATCH v2 1/3] spi: Added dummy_cycle entry in the spi_transfer structure. X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1148 Lines: 32 --3C3ZMpwu25Mtx3MN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Apr 07, 2016 at 08:09:27PM +0530, P L Sai Krishna wrote: > + * @dummy_cycles: number of dummy cycles. If host controller requires > + * dummy cycles rather than dummy bytes which send along with Cmd > + * and address then this dummy_cycles is used. I'm having a very hard time parsing this, partly because it is entirely flash specific (the whole concept of cmd and address is missing from SPI). As Cyrille said perhaps this should go in a flash specific interface? --3C3ZMpwu25Mtx3MN Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXDJE9AAoJECTWi3JdVIfQbdgH/i6pQrJlheEnY2+TpzqaJH9N 0gliGNtTfhiTWHRE+5bQwYR35WuWGrz21nKodsX1eTlHB9aF22Wee3zo7qRWodnp PwJpNcpKTTG2sjzAeC25gRQ2WYNHiQzgCou7kP3yut8AvsFTqyTa/mQ1yHXNW6dW 8sc63rb9zIFoFGF5vRRBfffADUv8GCOymFKGLVL+7nuSW+zi6xZc77FAZ+dToz54 qKpEinZ4cIUYuwKY7u3V5HYRyrfB3WhnkAM8DWFTxMVo5xp6ICPv8RBmEZZd1+jH ic74Pv1GUyckoB2mj9h9LTAoINTJVSW7adAtaZhIy3zw78oJz4tPNlvHnm0yNnE= =Rl6x -----END PGP SIGNATURE----- --3C3ZMpwu25Mtx3MN--