Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756005AbcDLGwn (ORCPT ); Tue, 12 Apr 2016 02:52:43 -0400 Received: from mga14.intel.com ([192.55.52.115]:57480 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750888AbcDLGwl convert rfc822-to-8bit (ORCPT ); Tue, 12 Apr 2016 02:52:41 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,472,1455004800"; d="scan'208";a="783030309" From: "Du, Changbin" To: Felipe Balbi CC: "gregkh@linuxfoundation.org" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] usb: dwc3: free dwc->regset on dwc3_debugfs_exit Thread-Topic: [PATCH] usb: dwc3: free dwc->regset on dwc3_debugfs_exit Thread-Index: AQHRkXxyY3OKy5PsYkGv+nYrf2hue5+D6PoAgACmx7D//417AIAAiixQ//+FhwCAAW89kP//wPOAABGE4pA= Date: Tue, 12 Apr 2016 06:52:37 +0000 Message-ID: <0C18FE92A7765D4EB9EE5D38D86A563A05CFEB0F@shsmsx102.ccr.corp.intel.com> References: <1460108522-31664-1-git-send-email-changbin.du@intel.com> <87bn5gpo1v.fsf@intel.com> <0C18FE92A7765D4EB9EE5D38D86A563A05CFE203@shsmsx102.ccr.corp.intel.com> <87shyso0tp.fsf@intel.com> <0C18FE92A7765D4EB9EE5D38D86A563A05CFE28D@shsmsx102.ccr.corp.intel.com> <87mvp0ny81.fsf@intel.com> <0C18FE92A7765D4EB9EE5D38D86A563A05CFE62A@shsmsx102.ccr.corp.intel.com> <877fg3mjti.fsf@intel.com> In-Reply-To: <877fg3mjti.fsf@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZGMwOWEyOGUtY2I2NC00Y2FiLWEzNTgtMTViNzliYmVlZTJjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Iks1XC9qT1hyV1RWSUlrNGxidXk5NnljNFpUTVVQXC8yXC9ZbFJOazJabU5BWm89In0= x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1067 Lines: 29 Hi, Balbi, > > Hmm, I agree from this point. I will combine this patch with other two > patches > > (due to their dependency). And I'd like remove the 'dwc->root=NULL' as > well, > > you are creating a dependency that doesn't exist. Please stop that. You > should have two separate branches based on v4.6-rc3 (or, if you prefer, > one based on my testing/fixes and another based on my testing/next). On > one branch you have *only* $subject and you fix *all* the memory > leaks. On the other branch you have the other two patches. > > Ignore the fact that we might have a conflict, that's for git (and > maintainers) to handle when they happen. > > Again, don't create dependencies between fixes for the -rc cycle and > changes for the next merge window. > Thanks for dedicated explanation. I was concern about the conflict. Now it is very clear for me to handle such situation. > > Is it ok for you? > > yeah, please remove root = NULL as that's completely unnecessary, but > split these patches in separate branches and fix all memory leaks. > > -- > balbi