Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756246AbcDLHdq (ORCPT ); Tue, 12 Apr 2016 03:33:46 -0400 Received: from ozlabs.org ([103.22.144.67]:37037 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754609AbcDLHdp (ORCPT ); Tue, 12 Apr 2016 03:33:45 -0400 From: Rusty Russell To: Jiri Kosina Cc: linux-kernel@vger.kernel.org, Andrew Morton Subject: Re: [PATCH v2] module: fix noreturn attribute for __module_put_and_exit() In-Reply-To: References: User-Agent: Notmuch/0.20.2 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Tue, 12 Apr 2016 17:00:35 +0930 Message-ID: <87d1pvnv1g.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 715 Lines: 22 Jiri Kosina writes: > On Wed, 30 Mar 2016, Jiri Kosina wrote: > >> > __module_put_and_exit() is makred noreturn in module.h declaration, but is >> > lacking the attribute in the definition, which makes some tools (such as >> > sparse) unhappy. Amend the definition with the attribute as well (and >> > reformat the declaration so that it uses more common format). >> > >> > Signed-off-by: Jiri Kosina >> > --- >> > >> > v1 -> v2: use __noreturn instead of __attribute__((noreturn)) as requested >> > by Rusty >> >> Rusty, friendly ping on this one. > > Not seeing this in your tree, let me send another friendly ping :) Just pushed it into modules-next. Cheers, Rusty.