Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756803AbcDLJid (ORCPT ); Tue, 12 Apr 2016 05:38:33 -0400 Received: from mx2.suse.de ([195.135.220.15]:42268 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753915AbcDLJic (ORCPT ); Tue, 12 Apr 2016 05:38:32 -0400 Subject: Re: mmotm woes, mainly compaction To: Hugh Dickins , Michal Hocko , Andrew Morton References: Cc: Michal Hocko , linux-kernel@vger.kernel.org, linux-mm@kvack.org From: Vlastimil Babka Message-ID: <570CC216.8030201@suse.cz> Date: Tue, 12 Apr 2016 11:38:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 878 Lines: 20 On 04/12/2016 09:18 AM, Hugh Dickins wrote: > 1. Fix crash in release_pages() from compact_zone() from kcompactd_do_work(): > kcompactd needs to INIT_LIST_HEAD on the new freepages_held list. Hmm, right. I didn't notice the new call site added by one series when rebasing the other series :/ > 4. Added VM_BUG_ONs to assert freepages_held is empty, matching those on > the other lists - though they're getting to look rather too much now. I think the easiest thing to do for now is to drop from mmotm: mm-compaction-direct-freepage-allocation-for-async-direct-compaction.patch As Mel and Joonsoo didn't like it in the current state anyway. > 6. Remove unused bool success from kcompactd_do_work(). That leaves just this part, which didn't fit anywhere else. I guess can just fold it to upcoming kcompactd patches? Thanks for organizing my morning today, Hugh :)