Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756386AbcDLN3T (ORCPT ); Tue, 12 Apr 2016 09:29:19 -0400 Received: from mail-lf0-f67.google.com ([209.85.215.67]:34618 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755795AbcDLN3R (ORCPT ); Tue, 12 Apr 2016 09:29:17 -0400 Date: Tue, 12 Apr 2016 15:29:13 +0200 From: =?utf-8?B?TWljaGHFgiBLxJlwaWXFhA==?= To: Jonathan Woithe , Darren Hart Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fujitsu-laptop: Support radio LED Message-ID: <20160412132913.GA2631@eudyptula.hq.kempniu.pl> References: <1458127687-25366-1-git-send-email-kernel@kempniu.pl> <20160318120418.GA29889@marvin.atrad.com.au> <20160322133051.GA3379@eudyptula.hq.kempniu.pl> <20160324113513.GA5129@marvin.atrad.com.au> <20160410023020.GA27081@dvhart-mobl5.amr.corp.intel.com> <20160410105258.GA2922@marvin.atrad.com.au> <20160412120323.GA2583@eudyptula.hq.kempniu.pl> <20160412124920.GB8195@marvin.atrad.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160412124920.GB8195@marvin.atrad.com.au> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 862 Lines: 20 > > Darren, even if Jonathan is happy with v1 code-wise, I was planning to > > post a v2 with an improved commit message (as hinted before [1]). Yet, > > the contents of that message may depend on the results of Jonathan's > > tests. > > No problem. You can use my posted suggestions as they are or edit as > appropriate. Note the suggested comment in the code regarding the use of > BTNI bit 24 - again, feel free to use it as is or make changes as you see > fit. Darren: I'm happy to wait for the v2 patch. Jonathan, thanks so much for taking the time to edit the commit message. I like the end result, so if you're happy with it as it is, so am I. Darren, feel free to use the version of this patch suggested by Jonathan. I am at your disposal in case you'd like me to take any further action regarding this patch. -- Best regards, Michał Kępień