Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934010AbcDLOGI (ORCPT ); Tue, 12 Apr 2016 10:06:08 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:52205 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932148AbcDLOGD (ORCPT ); Tue, 12 Apr 2016 10:06:03 -0400 X-AuditID: cbfec7f5-f792a6d000001302-d6-570d00c826e4 Subject: Re: [PATCH] arm64: dts: Add nodes for pdma0 and pdam1 for exynos7 To: Alim Akhtar , linux-arm-kernel@lists.infradead.org References: <1460465378-23486-1-git-send-email-alim.akhtar@samsung.com> Cc: catalin.marinas@arm.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, thomas.ab@samsung.com From: Krzysztof Kozlowski Message-id: <570D00C6.9000203@samsung.com> Date: Tue, 12 Apr 2016 16:05:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-version: 1.0 In-reply-to: <1460465378-23486-1-git-send-email-alim.akhtar@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrNLMWRmVeSWpSXmKPExsVy+t/xq7onGHjDDRY0sVo8mLeNzeL9sh5G i/lHzrFavH5haLHp8TVWi8u75rBZzDi/j8miYxmjxcuPJ1gcOD3WzFvD6LF5Sb1H35ZVjB6f N8kFsERx2aSk5mSWpRbp2yVwZZz8/oypoIu14tPWH+wNjJNYuhg5OSQETCRWvmpihLDFJC7c W8/WxcjFISSwlFFi29v37BDOM0aJ2VvOgHUIC3hJzH51HijBwSEi4C9x6UENSFhIwF3i9fTF YPXMAisYJb7uXsMKkmATMJbYvHwJG4jNK6AlcfXiCXYQm0VAVWLXxttgM0UFIiSezD3JCFEj KPFj8j0WkPmcAh4SN975gJjMAnoS9y9qgVQwC8hLbF7zlnkCo8AsJA2zEKpmIalawMi8ilE0 tTS5oDgpPddIrzgxt7g0L10vOT93EyMkyL/uYFx6zOoQowAHoxIPr6UbT7gQa2JZcWXuIUYJ DmYlEd6zf4FCvCmJlVWpRfnxRaU5qcWHGKU5WJTEeWfueh8iJJCeWJKanZpakFoEk2Xi4JRq YGyTs26bHZa7SN3xF4/qLGElkSKmpLiZa46Ehn4N655UV3H8vuS3CduX3/GNncd+qNGSg2k9 26zIfDPF1OjIhBaDtZZFPCEzoo98zY++EGhvPW+KtaylYVfKMqOjDPsvzFo5NfKaI8/DDUaO ZWddtgU8m33xgZU0C6fqVq9HxzjbJ387ljKrQYmlOCPRUIu5qDgRAIHA9QhuAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 629 Lines: 19 On 04/12/2016 02:49 PM, Alim Akhtar wrote: > This patch adds device tree nodes for pdma0 and pdma1 controllers > found on exynos7 SoCs. > > Signed-off-by: Alim Akhtar > --- > arch/arm64/boot/dts/exynos/exynos7.dtsi | 29 +++++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > I would prefer avoid adding all new stuff at the end because it is conflict-prone. Alphabetical order or by address... but none of these are used currently. How about putting it after 'gic' node? Anyway the code looks fine: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof