Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964837AbcDLOOF (ORCPT ); Tue, 12 Apr 2016 10:14:05 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:38082 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964786AbcDLOOC (ORCPT ); Tue, 12 Apr 2016 10:14:02 -0400 Date: Tue, 12 Apr 2016 07:14:01 -0700 From: Greg Kroah-Hartman To: Jiri Slaby Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Hans de Goede Subject: Re: [PATCH 3.14 15/76] USB: uas: Reduce can_queue to MAX_CMNDS Message-ID: <20160412141401.GB7996@kroah.com> References: <20160410183516.090999097@linuxfoundation.org> <20160410183516.631971075@linuxfoundation.org> <570B9000.1080705@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <570B9000.1080705@suse.cz> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1641 Lines: 42 On Mon, Apr 11, 2016 at 01:52:32PM +0200, Jiri Slaby wrote: > On 04/10/2016, 08:36 PM, Greg Kroah-Hartman wrote: > > 3.14-stable review patch. If anyone has any objections, please let me know. > > > > ------------------ > > > > From: Hans de Goede > > > > commit 55ff8cfbc4e12a7d2187df523938cc671fbebdd1 upstream. > > > > The uas driver can never queue more then MAX_CMNDS (- 1) tags and tags > > are shared between luns, so there is no need to claim that we can_queue > > some random large number. > > > > Not claiming that we can_queue 65536 commands, fixes the uas driver > > failing to initialize while allocating the tag map with a "Page allocation > > failure (order 7)" error on systems which have been running for a while > > and thus have fragmented memory. > > > > Reported-and-tested-by: Yves-Alexis Perez > > Signed-off-by: Hans de Goede > > Signed-off-by: Greg Kroah-Hartman > > > > --- > > drivers/usb/storage/uas.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > --- a/drivers/usb/storage/uas.c > > +++ b/drivers/usb/storage/uas.c > > @@ -835,7 +835,7 @@ static struct scsi_host_template uas_hos > > .eh_abort_handler = uas_eh_abort_handler, > > .eh_device_reset_handler = uas_eh_device_reset_handler, > > .eh_bus_reset_handler = uas_eh_bus_reset_handler, > > - .can_queue = 65536, /* Is there a limit on the _host_ ? */ > > + .can_queue = MAX_CMNDS, > > MAX_CMNDS is defined only since 3.18. (The driver is marked as BROKEN > till 3.15, anyway.) Ah, good point, now removed, thanks. greg k-h