Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934032AbcDLOcS (ORCPT ); Tue, 12 Apr 2016 10:32:18 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:39281 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933614AbcDLOcQ (ORCPT ); Tue, 12 Apr 2016 10:32:16 -0400 Date: Tue, 12 Apr 2016 07:31:44 -0700 From: Greg Kroah-Hartman To: Ben Hutchings Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Bjorn Helgaas , Andi Kleen Subject: Re: [PATCH 4.5 026/238] PCI: Disable IO/MEM decoding for devices with non-compliant BARs Message-ID: <20160412143144.GA10285@kroah.com> References: <20160410183456.398741366@linuxfoundation.org> <20160410183457.730080842@linuxfoundation.org> <1460418313.25201.69.camel@decadent.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1460418313.25201.69.camel@decadent.org.uk> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1240 Lines: 31 On Tue, Apr 12, 2016 at 12:45:13AM +0100, Ben Hutchings wrote: > On Sun, 2016-04-10 at 11:33 -0700, Greg Kroah-Hartman wrote: > > 4.5-stable review patch.??If anyone has any objections, please let me know. > > > > ------------------ > > > > From: Bjorn Helgaas > > > > commit b84106b4e2290c081cdab521fa832596cdfea246 upstream. > > > > The PCI config header (first 64 bytes of each device's config space) is > > defined by the PCI spec so generic software can identify the device and > > manage its usage of I/O, memory, and IRQ resources. > > > > Some non-spec-compliant devices put registers other than BARs where the > > BARs should be.??When the PCI core sizes these "BARs", the reads and writes > > it does may have unwanted side effects, and the "BAR" may appear to > > describe non-sensical address space. > > > > Add a flag bit to mark non-compliant devices so we don't touch their BARs. > > Turn off IO/MEM decoding to prevent the devices from consuming address > > space, since we can't read the BARs to find out what that address space > > would be. > [...] > > No objection, but patch 005/238 seems to depend on this so please > reorder them so bisection will work. Now reordered, thanks. greg k-h