Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933717AbcDLOon (ORCPT ); Tue, 12 Apr 2016 10:44:43 -0400 Received: from foss.arm.com ([217.140.101.70]:56270 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932834AbcDLOol (ORCPT ); Tue, 12 Apr 2016 10:44:41 -0400 Date: Tue, 12 Apr 2016 15:44:35 +0100 From: Catalin Marinas To: Will Deacon Cc: Ard Biesheuvel , Mark Rutland , Dan Zhao , mhocko@suse.com, Yiping Xu , puck.chen@foxmail.com, "linux-mm@kvack.org" , Chen Feng , suzhuangluan@hisilicon.com, David Rientjes , "linux-kernel@vger.kernel.org" , linuxarm@huawei.com, albert.lubing@hisilicon.com, "linux-arm-kernel@lists.infradead.org" , oliver.fu@hisilicon.com, Andrew Morton , Laura Abbott , robin.murphy@arm.com, kirill.shutemov@linux.intel.com, saberlily.xia@hisilicon.com Subject: Re: [PATCH 1/2] arm64: mem-model: add flatmem model for arm64 Message-ID: <20160412144434.GE8066@e104818-lin.cambridge.arm.com> References: <1459844572-53069-1-git-send-email-puck.chen@hisilicon.com> <20160407142148.GI5657@arm.com> <570B10B2.2000000@hisilicon.com> <570B5875.20804@hisilicon.com> <570B758E.7070005@hisilicon.com> <20160411104013.GG15729@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160411104013.GG15729@arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1336 Lines: 36 On Mon, Apr 11, 2016 at 11:40:13AM +0100, Will Deacon wrote: > On Mon, Apr 11, 2016 at 12:31:53PM +0200, Ard Biesheuvel wrote: > > On 11 April 2016 at 11:59, Chen Feng wrote: > > > Please see the pg-tables below. > > > > > > > > > With sparse and vmemmap enable. > > > > > > ---[ vmemmap start ]--- > > > 0xffffffbdc0200000-0xffffffbdc4800000 70M RW NX SHD AF UXN MEM/NORMAL > > > ---[ vmemmap end ]--- > > > > > > > OK, I see what you mean now. Sorry for taking so long to catch up. > > > > > The board is 4GB, and the memap is 70MB > > > 1G memory --- 14MB mem_map array. > > > > No, this is incorrect. 1 GB corresponds with 16 MB worth of struct > > pages assuming sizeof(struct page) == 64 > > > > So you are losing 6 MB to rounding here, which I agree is significant. > > I wonder if it makes sense to use a lower value for SECTION_SIZE_BITS > > on 4k pages kernels, but perhaps we're better off asking the opinion > > of the other cc'ees. > > You need to be really careful making SECTION_SIZE_BITS smaller because > it has a direct correlation on the use of page->flags and you can end up > running out of bits fairly easily. With SPARSEMEM_VMEMMAP, SECTION_SIZE_BITS no longer affect the page flags since we no longer need to encode the section number in page->flags. -- Catalin