Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964881AbcDLOvl (ORCPT ); Tue, 12 Apr 2016 10:51:41 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:36502 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932643AbcDLOvj (ORCPT ); Tue, 12 Apr 2016 10:51:39 -0400 Date: Tue, 12 Apr 2016 16:51:37 +0200 From: Michal Hocko To: Hugh Dickins Cc: Andrew Morton , Vlastimil Babka , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: mmotm woes, mainly compaction Message-ID: <20160412145136.GA4387@dhcp22.suse.cz> References: <20160412121020.GC10771@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160412121020.GC10771@dhcp22.suse.cz> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 666 Lines: 24 On Tue 12-04-16 14:10:20, Michal Hocko wrote: [...] > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 6d1da0ceaf1e..d80c9755ffc7 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -3030,8 +3030,8 @@ should_compact_retry(struct alloc_context *ac, int order, int alloc_flags, > * failure could be caused by weak migration mode. > */ > if (compaction_failed(compact_result)) { > - if (*migrate_mode == MIGRATE_ASYNC) { > - *migrate_mode = MIGRATE_SYNC_LIGHT; > + if (*migrate_mode < MIGRATE_SYNC) { > + *migrate_mode++; > return true; this should be (*migrate_mode)++ of course. > } > return false; -- Michal Hocko SUSE Labs