Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964921AbcDLO5H (ORCPT ); Tue, 12 Apr 2016 10:57:07 -0400 Received: from eusmtp01.atmel.com ([212.144.249.242]:32786 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756445AbcDLO5F (ORCPT ); Tue, 12 Apr 2016 10:57:05 -0400 Subject: Re: [PATCH RFT 2/2] macb: kill PHY reset code To: Sergei Shtylyov , Andrew Lunn References: <81129033.NXiOLTg1so@wasted.cogentembedded.com> <2811962.eGX2i5RJbZ@wasted.cogentembedded.com> <20160411022802.GB4307@lunn.ch> <570CBE42.50309@atmel.com> <570CFE13.3040100@cogentembedded.com> CC: , , Gregory CLEMENT From: Nicolas Ferre X-Enigmail-Draft-Status: N1110 Organization: atmel Message-ID: <570D0CD1.6070304@atmel.com> Date: Tue, 12 Apr 2016 16:57:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <570CFE13.3040100@cogentembedded.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.161.30.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1912 Lines: 61 Le 12/04/2016 15:54, Sergei Shtylyov a ?crit : > Hello. > > On 4/12/2016 12:22 PM, Nicolas Ferre wrote: > >>>> With the 'phylib' now being aware of the "reset-gpios" PHY node property, >>>> there should be no need to frob the PHY reset in this driver anymore... >>>> >>>> Signed-off-by: Sergei Shtylyov >>>> >>>> --- >>>> drivers/net/ethernet/cadence/macb.c | 17 ----------------- >>>> drivers/net/ethernet/cadence/macb.h | 1 - >>>> 2 files changed, 18 deletions(-) >>>> >>>> Index: net-next/drivers/net/ethernet/cadence/macb.c >>>> =================================================================== >>>> --- net-next.orig/drivers/net/ethernet/cadence/macb.c >>>> +++ net-next/drivers/net/ethernet/cadence/macb.c > [...] >>>> @@ -2977,18 +2976,6 @@ static int macb_probe(struct platform_de >>>> else >>>> macb_get_hwaddr(bp); >>>> >>>> - /* Power up the PHY if there is a GPIO reset */ >>>> - phy_node = of_get_next_available_child(np, NULL); >>>> - if (phy_node) { >>>> - int gpio = of_get_named_gpio(phy_node, "reset-gpios", 0); >>>> - >>>> - if (gpio_is_valid(gpio)) { >>>> - bp->reset_gpio = gpio_to_desc(gpio); >>>> - gpiod_direction_output(bp->reset_gpio, 1); >>> >>> Hi Sergei >>> >>> The code you are deleting would of ignored the flags in the gpio >> >> I don't parse this. > >> The code deleted does take the flag into account. > > Not really -- you need to call of_get_named_gpio_flags() (with a valid > last argument) for that. Yep, >> And the DT property >> associated to it seems correct to me (I mean, with proper flag >> specification). > > It apparently is not as it have GPIO_ACTIVE_HIGH and the driver assumes > active-low reset signal. Yes, logic was inverted and... anyway, the flag never used for real... Thanks Sergei. No problem for me accepting a patch for the at91-vinco.dts. Bye, -- Nicolas Ferre