Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965043AbcDLPAo (ORCPT ); Tue, 12 Apr 2016 11:00:44 -0400 Received: from foss.arm.com ([217.140.101.70]:56383 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964932AbcDLPAn (ORCPT ); Tue, 12 Apr 2016 11:00:43 -0400 Date: Tue, 12 Apr 2016 16:00:36 +0100 From: Catalin Marinas To: Xishi Qiu Cc: Chen Feng , mark.rutland@arm.com, dan.zhao@hisilicon.com, mhocko@suse.com, puck.chen@foxmail.com, ard.biesheuvel@linaro.org, suzhuangluan@hisilicon.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, linuxarm@huawei.com, linux-mm@kvack.org, kirill.shutemov@linux.intel.com, rientjes@google.com, oliver.fu@hisilicon.com, akpm@linux-foundation.org, robin.murphy@arm.com, yudongbin@hislicon.com, linux-arm-kernel@lists.infradead.org, saberlily.xia@hisilicon.com Subject: Re: [PATCH 2/2] arm64: mm: make pfn always valid with flat memory Message-ID: <20160412150036.GG8066@e104818-lin.cambridge.arm.com> References: <1459844572-53069-1-git-send-email-puck.chen@hisilicon.com> <1459844572-53069-2-git-send-email-puck.chen@hisilicon.com> <570B85B6.8000805@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <570B85B6.8000805@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 953 Lines: 29 On Mon, Apr 11, 2016 at 07:08:38PM +0800, Xishi Qiu wrote: > On 2016/4/5 16:22, Chen Feng wrote: > > > Make the pfn always valid when using flat memory. > > If the reserved memory is not align to memblock-size, > > there will be holes in zone. > > > > This patch makes the memory in buddy always in the > > array of mem-map. > > > > Signed-off-by: Chen Feng > > Signed-off-by: Fu Jun > > --- > > arch/arm64/mm/init.c | 7 ++++--- > > 1 file changed, 4 insertions(+), 3 deletions(-) > > > > diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c > > index ea989d8..0e1d5b7 100644 > > --- a/arch/arm64/mm/init.c > > +++ b/arch/arm64/mm/init.c > > @@ -306,7 +306,8 @@ static void __init free_unused_memmap(void) > > How about let free_unused_memmap() support for CONFIG_SPARSEMEM_VMEMMAP? We would need extra care to check that the memmap was actually allocated in the first place. -- Catalin