Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965984AbcDLPv4 (ORCPT ); Tue, 12 Apr 2016 11:51:56 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:44778 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965595AbcDLPvy (ORCPT ); Tue, 12 Apr 2016 11:51:54 -0400 Date: Tue, 12 Apr 2016 17:51:49 +0200 From: Peter Zijlstra To: xlpang@redhat.com Cc: Steven Rostedt , linux-kernel@vger.kernel.org, Juri Lelli , Ingo Molnar , Thomas Gleixner Subject: Re: [PATCH] sched/deadline/rtmutex: Fix a PI crash for deadline tasks Message-ID: <20160412155149.GJ1087@worktop> References: <20160405091954.GI3448@twins.programming.kicks-ass.net> <20160405092954.GC24771@twins.programming.kicks-ass.net> <20160408122510.15978179@gandalf.local.home> <20160408173835.GC1087@worktop> <20160408145055.13c98a75@gandalf.local.home> <20160408185916.GQ3448@twins.programming.kicks-ass.net> <57087633.3020700@redhat.com> <20160409132935.GU3448@twins.programming.kicks-ass.net> <570A0D37.8080400@redhat.com> <570C6694.50803@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <570C6694.50803@redhat.com> User-Agent: Mutt/1.5.22.1 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 247 Lines: 5 On Tue, Apr 12, 2016 at 11:08:04AM +0800, Xunlei Pang wrote: > I spotted another issue, we access pi_task without any lock in enqueue_task_dl(), OK, so I'm on the road and entirely jetlagged, but how can enqueue_task_dl() not have rq->lock held?