Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030302AbcDLPyN (ORCPT ); Tue, 12 Apr 2016 11:54:13 -0400 Received: from mail-wm0-f43.google.com ([74.125.82.43]:37286 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965859AbcDLPxu (ORCPT ); Tue, 12 Apr 2016 11:53:50 -0400 Date: Tue, 12 Apr 2016 16:53:47 +0100 From: Matt Fleming To: Michal Hocko Cc: linux-mm@kvack.org, Andrew Morton , LKML , Michal Hocko , linux-arch@vger.kernel.org Subject: Re: [PATCH 03/19] x86/efi: get rid of superfluous __GFP_REPEAT Message-ID: <20160412155347.GF2829@codeblueprint.co.uk> References: <1460372892-8157-1-git-send-email-mhocko@kernel.org> <1460372892-8157-4-git-send-email-mhocko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1460372892-8157-4-git-send-email-mhocko@kernel.org> User-Agent: Mutt/1.5.24+41 (02bc14ed1569) (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 794 Lines: 20 On Mon, 11 Apr, at 01:07:56PM, Michal Hocko wrote: > From: Michal Hocko > > __GFP_REPEAT has a rather weak semantic but since it has been introduced > around 2.6.12 it has been ignored for low order allocations. > > efi_alloc_page_tables uses __GFP_REPEAT but it allocates an order-0 > page. This means that this flag has never been actually useful here > because it has always been used only for PAGE_ALLOC_COSTLY requests. > > Cc: Matt Fleming > Cc: linux-arch@vger.kernel.org > Signed-off-by: Michal Hocko > --- > arch/x86/platform/efi/efi_64.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Looks fine. I suspect I copied it from other pgtable creation code, Reviewed-by: Matt Fleming