Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966015AbcDLQJV (ORCPT ); Tue, 12 Apr 2016 12:09:21 -0400 Received: from mail-lf0-f47.google.com ([209.85.215.47]:34710 "EHLO mail-lf0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932606AbcDLQJT (ORCPT ); Tue, 12 Apr 2016 12:09:19 -0400 MIME-Version: 1.0 In-Reply-To: <1460451517-171713-1-git-send-email-lipengcheng8@huawei.com> References: <1460451517-171713-1-git-send-email-lipengcheng8@huawei.com> Date: Tue, 12 Apr 2016 10:09:17 -0600 Message-ID: Subject: Re: [PATCH] coresight: etm4x: modify q_support type From: Mathieu Poirier To: lipengcheng Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , lizhong11@hisilicon.com, Feng Chen , liuyongfu@hisilicon.com, Dan Zhao Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1339 Lines: 37 On 12 April 2016 at 02:58, lipengcheng wrote: > Because this operation exceed the range of boolean, so we should > modify q_support to unit32 bit. > drvdata->q_support = BMVAL(etmidr0, 15, 16) > > Signed-off-by: Li Pengcheng > Signed-off-by: Li Zhong > --- > drivers/hwtracing/coresight/coresight-etm4x.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hwtracing/coresight/coresight-etm4x.h b/drivers/hwtracing/coresight/coresight-etm4x.h > index c341002..305b29a 100644 > --- a/drivers/hwtracing/coresight/coresight-etm4x.h > +++ b/drivers/hwtracing/coresight/coresight-etm4x.h > @@ -330,7 +330,7 @@ struct etmv4_drvdata { > u32 ccctlr; > bool trcbb; > u32 bb_ctrl; > - bool q_support; > + u32 q_support; Unfortunately this patch doesn't apply on my side. Please rebase on my next tree [1], branch "next". Thanks, Mathieu [1]. https://git.linaro.org/kernel/coresight.git > u32 vinst_ctrl; > u32 viiectlr; > u32 vissctlr; > -- > 1.8.3.2 >