Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933062AbcDLQcE (ORCPT ); Tue, 12 Apr 2016 12:32:04 -0400 Received: from muru.com ([72.249.23.125]:50496 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932552AbcDLQcC (ORCPT ); Tue, 12 Apr 2016 12:32:02 -0400 Date: Tue, 12 Apr 2016 09:31:57 -0700 From: Tony Lindgren To: Rob Herring Cc: Frank Rowand , Grant Likely , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , linux-omap Subject: Re: [PATCH] of/platform: Allow secondary compatible match in of_dev_lookup Message-ID: <20160412163156.GQ5995@atomide.com> References: <1459546504-32668-1-git-send-email-tony@atomide.com> <20160401214053.GQ9329@atomide.com> <20160407165842.GJ16484@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2172 Lines: 51 * Rob Herring [160412 08:57]: > On Thu, Apr 7, 2016 at 11:58 AM, Tony Lindgren wrote: > > * Rob Herring [160406 21:53]: > >> On Fri, Apr 1, 2016 at 4:40 PM, Tony Lindgren wrote: > >> > * Tony Lindgren [160401 14:37]: > >> >> We currently try to match of_dev_auxdata based on compatible, > >> >> IO address, and device name. But in some cases we have multiple > >> >> instances of drivers that can use the same auxdata. > >> >> > >> >> Let's add an additional secondary lookup for generic compatible > >> >> match for auxdata if no device specific match is found. This does > >> >> not change the existing matching, and still allows adding device > >> >> specific auxdata. > >> >> > >> >> This simplifies things as specifying the IO address and device > >> >> name is prone errors as it requires maintaining an in kernel > >> >> database for each SoC. > >> > > >> > And here's what I can apply later on to get rid of some > >> > ifdeffery. > >> > > >> > I'm also planning to move some of the legacy omap hwmod > >> > functionality into proper device drivers, so can generic > >> > pdata for that too. > >> > >> Why can't the platform data be moved into the driver given that it > >> appears to be only SoC family specific? Auxdata was somewhat intended > >> to be temporary. It appears there is already some per compatible match > >> data for these OMAP parts in the driver. > > > > There are just too many dependencies to move legacy code into drivers > > directly. Especially when moving the omap hwmod code into drivers, > > we still to use hwmod callbacks at least for clockdomain configuration, > > wake-up dependencies and clock autogating configuration. > > > > When we have Linux generic frameworks available for all this we no longer > > need the auxdata. But meanwhile, removing the depenencies by using > > auxdata already allows moving big chunks of the hwmod code into regular > > device drivers. > > Okay. In that case: > > Acked-by: Rob Herring > > Apply it when you have actual users depending on it. OK thanks will do. Regards, Tony