Message-ID: <1460483357.2507.24.camel@perches.com>
Subject: Re: checkpatch false positon on EXPORT_SYMBOL
From: Joe Perches <joe@perches.com>
To: Andy Whitcroft <apw@canonical.com>
Cc: Daniel Walker <danielwa@cisco.com>,
        open list <linux-kernel@vger.kernel.org>,
        Daniel Walker <dwalker@fifo99.com>,
        "xe-kernel@external.cisco.com" <xe-kernel@external.cisco.com>
Date: Tue, 12 Apr 2016 10:49:17 -0700
In-Reply-To: <20160412125904.GB5107@brain>
References: <56FD3BAE.1070209@cisco.com>
	 <1459452096.1744.12.camel@perches.com> <570C1C62.1060008@cisco.com>
	 <1460412582.1800.96.camel@perches.com> <20160412125904.GB5107@brain>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 688
Lines: 22

> On Tue, 2016-04-12 at 13:59 +0100, Andy Whitcroft wrote:
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -3000,7 +3000,7 @@ sub process {
> 
> ?			$realline_next = $line_nr_next;
> ?			if (defined $realline_next &&
> ?			????(!defined $lines[$realline_next - 1] ||
> -			?????substr($lines[$realline_next - 1], $off_next) =~ /^\s*$/)) {
> +			?????substr($lines[$realline_next - 1], $off_next) =~ /^($;|\s)*$/)) {
> ?				$realline_next++;
> ??			}

This doesn't work with c99 comments like:

int foo;		// comment
EXPORT_SYMBOL(foo);	// comment

but then again, there aren't any uses like that in the
kernel tree so it almost certainly doesn't matter.

Thanks Andy.