Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965071AbcDLSDN (ORCPT ); Tue, 12 Apr 2016 14:03:13 -0400 Received: from bby1mta02.pmc-sierra.com ([216.241.235.117]:36238 "EHLO bby1mta02.pmc-sierra.bc.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933839AbcDLSDK (ORCPT ); Tue, 12 Apr 2016 14:03:10 -0400 From: Raghava Aditya Renukunta To: Ben Hutchings CC: "stable@vger.kernel.org" , Shane Seymour , Johannes Thumshirn , "Martin K. Petersen" , Greg Kroah-Hartman , LKML Subject: RE: [PATCH 4.5 036/238] aacraid: Set correct msix count for EEH recovery Thread-Topic: [PATCH 4.5 036/238] aacraid: Set correct msix count for EEH recovery Thread-Index: AQHRk1gbtl2zXyHWskOmy1wyHe4Cup+F80mAgACweXA= Date: Tue, 12 Apr 2016 18:01:46 +0000 Message-ID: <198D06D448A18D4E93F08FB849C4E39D7D224C43@BBYEXM01.pmc-sierra.internal> References: <20160410183456.398741366@linuxfoundation.org> <20160410183458.424247219@linuxfoundation.org> <1460420943.25201.71.camel@decadent.org.uk> In-Reply-To: <1460420943.25201.71.camel@decadent.org.uk> Accept-Language: en-US, en-CA Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [216.241.227.4] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u3CI3K0Z012201 Content-Length: 2143 Lines: 68 Hello Ben, > -----Original Message----- > From: Ben Hutchings [mailto:ben@decadent.org.uk] > Sent: Monday, April 11, 2016 5:29 PM > To: Raghava Aditya Renukunta > Cc: stable@vger.kernel.org; Shane Seymour; Johannes Thumshirn; Martin K. > Petersen; Greg Kroah-Hartman; LKML > Subject: Re: [PATCH 4.5 036/238] aacraid: Set correct msix count for EEH > recovery > > On Sun, 2016-04-10 at 11:33 -0700, Greg Kroah-Hartman wrote: > > 4.5-stable review patch.  If anyone has any objections, please let me know. > > > > ------------------ > > > > From: Raghava Aditya Renukunta > > > > commit ecc479e00db8eb110b200afe1effcb3df20ca7ae upstream. > > > > During EEH recovery number of online CPU's might change thereby > changing > > the number of MSIx vectors. Since each fib is allocated to a vector, > > changes in the number of vectors causes fib to be sent thru invalid > > vectors.In addition the correct number of MSIx vectors is not updated in > > the INIT struct sent to the controller, when it is reinitialized. > > > > Fixed by reassigning vectors to fibs based on the updated number of MSIx > > vectors and updating the INIT structure before sending to controller. > > Really? > > [...] > > --- a/drivers/scsi/aacraid/linit.c > > +++ b/drivers/scsi/aacraid/linit.c > > @@ -1404,8 +1404,18 @@ static int aac_acquire_resources(struct > > > >   aac_adapter_enable_int(dev); > > > > - if (!dev->sync_mode) > > + /*max msix may change  after EEH > > +  * Re-assign vectors to fibs > > +  */ > > + aac_fib_vector_assign(dev); > > + > > + if (!dev->sync_mode) { > > + /* After EEH recovery or suspend resume, max_msix count > > +  * may change, therfore updating in init as well. > > +  */ > >   aac_adapter_start(dev); > > + dev->init->Sa_MSIXVectors = cpu_to_le32(dev->max_msix); > > Aren't these two lines in the wrong order? > > Ben. You are right those are two lines are in the wrong order, I will submit another patch to correct that issue. Raghava > > > + } > >   return 0; > > > >  error_iounmap: > -- > Ben Hutchings > This sentence contradicts itself - no actually it doesn't.