Message-ID: <1460486340.25714.10.camel@tiscali.nl>
Subject: Re: [PATCH 4.5 128/238] ALSA: hda - Fix missing ELD update at
 unplugging
From: Paul Bolle <pebolle@tiscali.nl>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Takashi Iwai <tiwai@suse.de>
Cc: Libin Yang <libin.yang@linux.intel.com>, linux-kernel@vger.kernel.org,
        stable@vger.kernel.org
Date: Tue, 12 Apr 2016 20:39:00 +0200
In-Reply-To: <20160410183503.651874957@linuxfoundation.org>
References: <20160410183456.398741366@linuxfoundation.org>
	 <20160410183503.651874957@linuxfoundation.org>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 946
Lines: 29

On zo, 2016-04-10 at 11:35 -0700, Greg Kroah-Hartman wrote:
> --- a/sound/pci/hda/patch_hdmi.c
> +++ b/sound/pci/hda/patch_hdmi.c
> @@ -1670,11 +1670,10 @@ static void sync_eld_via_acomp(struct hd
>  	int size;
>  
>  	mutex_lock(&per_pin->lock);
> +	eld->monitor_present = false;
>  	size = snd_hdac_acomp_get_eld(&codec->bus->core, per_pin->pin_nid,
>  				      &eld->monitor_present, eld->eld_buffer,
>  				      ELD_MAX_SIZE);
> -	if (size < 0)
> -		goto unlock;

This hunk triggers an obviously correct warning:
    sound/pci/hda/patch_hdmi.c: In function 'sync_eld_via_acomp':
    sound/pci/hda/patch_hdmi.c:1695:2: warning: label 'unlock' defined but not used [-Wunused-label]
      unlock:
      ^

It's trivial to silence this warning for the v4.5 stable build, of
course. But I never saw this warning in my v4.6-rc builds, so it's
possible another patch should also be included in the v4.5 stable tree.
Takashi?

Thanks,


Paul Bolle