Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965740AbcDLSu1 (ORCPT ); Tue, 12 Apr 2016 14:50:27 -0400 Received: from mail-pf0-f182.google.com ([209.85.192.182]:33726 "EHLO mail-pf0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933775AbcDLSu0 (ORCPT ); Tue, 12 Apr 2016 14:50:26 -0400 Subject: Re: [PATCH 1/4] drivers/bus: make brcmstb_gisb.c driver explicitly non-modular To: Brian Norris , Paul Gortmaker References: <1459113058-14340-1-git-send-email-paul.gortmaker@windriver.com> <1459113058-14340-2-git-send-email-paul.gortmaker@windriver.com> <20160407012639.GA30748@localhost> Cc: linux-kernel@vger.kernel.org, Olof Johansson , Will Deacon , Arnd Bergmann , Gregory Fong , linux-arm-kernel@lists.infradead.org From: Florian Fainelli Message-ID: <570D42F5.6070308@gmail.com> Date: Tue, 12 Apr 2016 11:48:21 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160407012639.GA30748@localhost> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1270 Lines: 36 On 06/04/16 18:26, Brian Norris wrote: > On Sun, Mar 27, 2016 at 05:10:55PM -0400, Paul Gortmaker wrote: >> The Kconfig for this driver is currently: >> >> config BRCMSTB_GISB_ARB >> bool "Broadcom STB GISB bus arbiter" >> >> ...meaning that it currently is not being built as a module by anyone. >> Lets remove all modular references, so that when reading the driver >> there is no doubt it is builtin-only. >> >> Since module_init translates to device_initcall in the non-modular >> case, the init ordering remains unchanged with this commit. >> >> Cc: Brian Norris >> Cc: Gregory Fong >> Cc: Florian Fainelli >> Cc: linux-arm-kernel@lists.infradead.org >> Signed-off-by: Paul Gortmaker > > I think this driver probably doesn't make too much sense as a module > anyway (among other things, we can't hook the ARM fault handler beyond > init time, as it's marked __init). So: > > Acked-by: Brian Norris > > Might be good to get Florian's ack though, as I'm not using this > platform any more. I concur with Brian here, your changes look good: Acked-by: Florian Fainelli Thanks Paul -- Florian