Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965730AbcDLVOK (ORCPT ); Tue, 12 Apr 2016 17:14:10 -0400 Received: from sauhun.de ([89.238.76.85]:59499 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933250AbcDLVOH (ORCPT ); Tue, 12 Apr 2016 17:14:07 -0400 Date: Tue, 12 Apr 2016 23:13:56 +0200 From: Wolfram Sang To: Liguo Zhang Cc: srv_heupstream@mediatek.com, Matthias Brugger , Eddie Huang , Xudong Chen , Sascha Hauer , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v3] i2c: mediatek: i2c multi transfer optimization Message-ID: <20160412211355.GA1526@katana> References: <1457375031-3769-1-git-send-email-liguo.zhang@mediatek.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ZGiS0Q5IWpPtfppv" Content-Disposition: inline In-Reply-To: <1457375031-3769-1-git-send-email-liguo.zhang@mediatek.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1711 Lines: 50 --ZGiS0Q5IWpPtfppv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, thanks for the submission! On Tue, Mar 08, 2016 at 02:23:51AM +0800, Liguo Zhang wrote: > Signal complete() in the i2c irq handler after one transfer done, > and then wait_for_completion_timeout() will return, this procedure > may cost much time, so only signal complete() when the entire > transaction has been completed, it will reduce the entire transaction > time. >=20 > Signed-off-by: Liguo Zhang I wonder. You have less context switches, yes. On the other hand, you likely have bigger interrupt latency because you do more stuff in the interrupt handler. Is it really a gain in the end? Regards, Wolfram --ZGiS0Q5IWpPtfppv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXDWUTAAoJEBQN5MwUoCm2WqEP/iYiA940CEMWOPhx/RgpbdHq +PoAO7geqKgb/u6b/HAtVdyXFpsnC3db3C6PFWg84q8gesh3HrmfarekIXcKQiGo /VHwXhSTbxu4KE4T4XlSzOlokb7Er7cJmg+P5Jv99CjpTAZGo00UfsxkUArca+5s J2fDV5/T1Q1hg8UFxdYTAukm7gB+lDyL8jBnDl9qCz4wWn5lfR0B1FBp8tyzjOIE CoWxx3B6FBAZh8pQYTHtWGf0TW1lIvG/bqu24upfV0Yf8m9UIFr2W1Op2v/Y5GC2 JVnqJXZ7GtCbZTSMK5cU3yEHiRQE+dbPy017j3N4Ul6NUMYMv5aontfAt/Af1Nhx ruY8tDuk/izDN+zN4nTSCT4B6r/jMLpkCBoMHuKpXL6CsbJbiT+huYDubuxzAuH3 YoJP/Nhoz98JFtYuBTk6L1l8UFK3w0V8paIwrSii92SdMvnntPaTUkBqMmtkn11a 40Lq+OYLGGT5XDuPp91KFrRFhO5PLPSgZwt0KCjLVC3HN6dcnd7rQbRbP50yanZB EB8vPOwjKHjLaMBtjwSM85Gzv7PVjfw3YLEwSD0yg6bNjHE5f0wz74le/Y4tKYW5 zSXIlnCyv3+DoWMNr6sQu/aiHnlm5chUT5EcgJFXSYpm/Eb5QN6Dh8XqHXf8DrQ/ ZQTnCbTXdgklOqhSVrlg =83yL -----END PGP SIGNATURE----- --ZGiS0Q5IWpPtfppv--