Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030189AbcDLVZg (ORCPT ); Tue, 12 Apr 2016 17:25:36 -0400 Received: from sauhun.de ([89.238.76.85]:59548 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755951AbcDLVZc (ORCPT ); Tue, 12 Apr 2016 17:25:32 -0400 Date: Tue, 12 Apr 2016 23:25:22 +0200 From: Wolfram Sang To: Vaishali Thakkar Cc: mmarek@suse.com, nm@ti.com, linux-kernel@vger.kernel.org, cocci@systeme.lip6.fr Subject: Re: [Cocci] [PATCH] Coccinelle: setup_timer: Add space in front of parentheses Message-ID: <20160412212522.GC1526@katana> References: <1458451652-5933-1-git-send-email-vaishali.thakkar@oracle.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="nmemrqcdn5VTmUEE" Content-Disposition: inline In-Reply-To: <1458451652-5933-1-git-send-email-vaishali.thakkar@oracle.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1528 Lines: 42 --nmemrqcdn5VTmUEE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Mar 20, 2016 at 10:57:32AM +0530, Vaishali Thakkar wrote: > Add space in front of the offending parentheses to silent the > parse error for older Coccinelle versions. This makes the rule > usable with all Coccinelle versions. >=20 > Reported-by: Nishanth Menon > Signed-off-by: Vaishali Thakkar Tested-by: Wolfram Sang Can we have this in 4.6 as a bugfix? The script is totally broken this way. --nmemrqcdn5VTmUEE Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXDWfCAAoJEBQN5MwUoCm2aeMP/2MN0LH+v3Ij+0Kumw4KwxxE g2MbZSmSkZ/kKnkXG0s4L6OtaWu/4wddgQrAhJN89cBUVVbQtL2rVnODUh0p7TEz Fq1uSb2gp38l9QdXxqVxN+lOxpOnQu/2hsOxgPEgJ69eU6n7XZ7VNalNj4NSMCd6 gnvi6hnN2M1ealbRQFOfDb1EeviMsREvG5p3CqWGODU6KPRdthki2xSvtwDlr9Jl zaWL8Kxt2z901jJRRtAGBC9rGPOQ+7ygzpohBKOVCExUldgmpf3E2P28Cy1NvDHf Sm5Oy5/7o7y3GPXs8DYBb/rCaNtrqmEcssoTop9xdmQjpFUVvixe51GVnaTry3c/ Fw77DCA54G76fcK0Wme/E6U7OXLwDpEJgDM6rx4kj/OCs1msKPH+tKXKcpXhXeQd VYkT86XGiLzW8zTf4KAqhiLK1I8Nhe086VAjQDz2N6/ydRR0SJIfcRrj+i00y1PE BuIk/nOh/vFc75l9a0dPzcxMx0Xw5dkrSzK4eN+6pwjacVlKtruZtE3M2A3gZxO7 WdMXDzgmYmcFymjzSiwtjeBjYSLBAmigUJl8HO7vtnfz3AQG9aRfkV1qvvVdreYY UIgh4zganFHyfDr4Fa4cKZw+GG2LkEZOA5ZdPYIqX1HvgPhll5JNc6BucsDAEXAZ xs++bgOHyPFN8xXuSrHz =kHVj -----END PGP SIGNATURE----- --nmemrqcdn5VTmUEE--