Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965288AbcDMD5R (ORCPT ); Tue, 12 Apr 2016 23:57:17 -0400 Received: from mga09.intel.com ([134.134.136.24]:16143 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933331AbcDMD5R (ORCPT ); Tue, 12 Apr 2016 23:57:17 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,477,1455004800"; d="scan'208";a="953789600" Date: Wed, 13 Apr 2016 04:14:48 +0800 From: Yuyang Du To: Dietmar Eggemann Cc: peterz@infradead.org, mingo@kernel.org, linux-kernel@vger.kernel.org, bsegall@google.com, pjt@google.com, morten.rasmussen@arm.com, vincent.guittot@linaro.org, juri.lelli@arm.com Subject: Re: [PATCH 2/4] sched/fair: Drop out incomplete current period when sched averages accrue Message-ID: <20160412201448.GL8697@intel.com> References: <1460327765-18024-1-git-send-email-yuyang.du@intel.com> <1460327765-18024-3-git-send-email-yuyang.du@intel.com> <570CE3F2.5000806@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <570CE3F2.5000806@arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 680 Lines: 28 On Tue, Apr 12, 2016 at 01:02:58PM +0100, Dietmar Eggemann wrote: > On 10/04/16 23:36, Yuyang Du wrote: > > [...] > > > @@ -2704,11 +2694,14 @@ static __always_inline int > > __update_load_avg(u64 now, int cpu, struct sched_avg *sa, > > unsigned long weight, int running, struct cfs_rq *cfs_rq) > > { > > - u64 delta, scaled_delta, periods; > > - u32 contrib; > > - unsigned int delta_w, scaled_delta_w, decayed = 0; > > + u64 delta; > > + u32 contrib, periods; > > unsigned long scale_freq, scale_cpu; > > > > + /* > > + * now rolls down to a period boundary > > + */ > > + now = now && (u64)(~0xFFFFF); > > This forces now to be 1. > > s/&&/& Duh, :) Thanks.