Message-ID: <1460520294.24619.18.camel@perches.com>
Subject: Re: [PATCH 2/4] sched/fair: Drop out incomplete current period when
 sched averages accrue
From: Joe Perches <joe@perches.com>
To: Yuyang Du <yuyang.du@intel.com>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>
Cc: peterz@infradead.org, mingo@kernel.org, linux-kernel@vger.kernel.org,
        bsegall@google.com, pjt@google.com, morten.rasmussen@arm.com,
        vincent.guittot@linaro.org, juri.lelli@arm.com
Date: Tue, 12 Apr 2016 21:04:54 -0700
In-Reply-To: <20160412201448.GL8697@intel.com>
References: <1460327765-18024-1-git-send-email-yuyang.du@intel.com>
	 <1460327765-18024-3-git-send-email-yuyang.du@intel.com>
	 <570CE3F2.5000806@arm.com> <20160412201448.GL8697@intel.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 809
Lines: 27

On Wed, 2016-04-13 at 04:14 +0800, Yuyang Du wrote:
> On Tue, Apr 12, 2016 at 01:02:58PM +0100, Dietmar Eggemann wrote:
> > On 10/04/16 23:36, Yuyang Du wrote:
> > [...]
> > > @@ -2704,11 +2694,14 @@ static __always_inline int
> > > ?__update_load_avg(u64 now, int cpu, struct sched_avg *sa,
> > > ?		??unsigned long weight, int running, struct cfs_rq *cfs_rq)
> > > ?{
> > > -	u64 delta, scaled_delta, periods;
> > > -	u32 contrib;
> > > -	unsigned int delta_w, scaled_delta_w, decayed = 0;
> > > +	u64 delta;
> > > +	u32 contrib, periods;
> > > ?	unsigned long scale_freq, scale_cpu;
> > > ?
> > > +	/*
> > > +	?* now rolls down to a period boundary
> > > +	?*/
> > > +	now = now && (u64)(~0xFFFFF);
> > This forces now to be 1.
> > 
> > s/&&/&
> Duh, :)

You could also avoid the cast:

	now &= 0xFFFFull;