Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754335AbcDMEjZ (ORCPT ); Wed, 13 Apr 2016 00:39:25 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:33305 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754021AbcDMEjW (ORCPT ); Wed, 13 Apr 2016 00:39:22 -0400 X-AuditID: cbfee690-f79e56d0000012c4-6c-570dcd777fb8 Message-id: <570DCD86.40208@samsung.com> Date: Wed, 13 Apr 2016 10:09:34 +0530 From: Alim Akhtar User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-version: 1.0 To: Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org Cc: catalin.marinas@arm.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, thomas.ab@samsung.com Subject: Re: [PATCH] arm64: dts: Add nodes for pdma0 and pdam1 for exynos7 References: <1460465378-23486-1-git-send-email-alim.akhtar@samsung.com> <570D00C6.9000203@samsung.com> In-reply-to: <570D00C6.9000203@samsung.com> Content-type: text/plain; charset=windows-1252; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrIIsWRmVeSWpSXmKPExsVy+t8zA93ys7zhBhdXa1q8X9bDaDH/yDlW i9cvDC02Pb7GanF51xw2ixnn9zFZdCxjtHj58QSLA4fHmnlrGD02L6n36NuyitHj8ya5AJYo LpuU1JzMstQifbsEroyd9w8yFlxlq3j1+hhjA+Mm1i5GTg4JAROJq9deMULYYhIX7q1n62Lk 4hASWMko8W/3TEaYovsXVrJAJJYySmyau4UJwnnAKPFt7g4WkCpeAQ2JyQubmEBsFgFViYkb ethAbDYBbYm700EaODhEBSIkHl8QgigXlPgx+R5Yq4hApMSLPecYQWYyC6xglPi6ew3YecIC XhKzX51nB7GFBDIk+jc3MYPYnEAze6f1gjUzC9hKLHi/DsqWl9i85i0zyCAJgXPsEs87pjJC HCQg8W3yIRaQIyQEZCU2HWCG+ExS4uCKGywTGMVmIblpFpKxs5CMXcDIvIpRNLUguaA4Kb3I RK84Mbe4NC9dLzk/dxMjJOYm7GC8d8D6EKMAB6MSD++FNbzhQqyJZcWVuYcYTYGumMgsJZqc D4zsvJJ4Q2MzIwtTE1NjI3NLMyVx3tdSP4OFBNITS1KzU1MLUovii0pzUosPMTJxcEo1MHam +63Oeb7ynPP2l5UWHs4/aht6j1uWWzPcCbuwYn/J1v3X/zo7Mu0u6GZ/q3ljidjzHSGKga+i uSd1yS35NOHdtf9PPBy1/kp0vZ2Q0udStatWu75ZUvjfqa+79n/xMjE/YfTZKufbpAert5vY fgq5HbphnnbWybj8SfE2xjqvJI4LsPXPTlZiKc5INNRiLipOBACqhh0OtAIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrHIsWRmVeSWpSXmKPExsVy+t9jAd3ys7zhBi/eq1i8X9bDaDH/yDlW i9cvDC02Pb7GanF51xw2ixnn9zFZdCxjtHj58QSLA4fHmnlrGD02L6n36NuyitHj8ya5AJao BkabjNTElNQihdS85PyUzLx0WyXv4HjneFMzA0NdQ0sLcyWFvMTcVFslF58AXbfMHKAjlBTK EnNKgUIBicXFSvp2mCaEhrjpWsA0Ruj6hgTB9RgZoIGEdYwZO+8fZCy4ylbx6vUxxgbGTaxd jJwcEgImEvcvrGSBsMUkLtxbz9bFyMUhJLCUUWLT3C1MEM4DRolvc3eAVfEKaEhMXtjEBGKz CKhKTNzQwwZiswloS9ydDtLAwSEqECHx+IIQRLmgxI/J98BaRQQiJV7sOccIMpNZYAWjxNfd a8CuEBbwkpj96jw7iC0kkCHRv7mJGcTmBJrZO60XrJlZwFZiwft1ULa8xOY1b5knMArMQrJj FpKyWUjKFjAyr2KUSC1ILihOSs81zEst1ytOzC0uzUvXS87P3cQIjutnUjsYD+5yP8QowMGo xMN7YQ1vuBBrYllxZe4hRgkOZiUR3rmHgUK8KYmVValF+fFFpTmpxYcYTYGBMJFZSjQ5H5hy 8kriDY1NzIwsjcwsjEzMzZXEeR//XxcmJJCeWJKanZpakFoE08fEwSnVwOgx51TTvU9pXzcr NNU8v+0mnsN9X05mYljOz5uLD2cENycmzlorVnW/757kPK7nm4/tNGsVuJZ77dGXPRIPNpvp f16rMS8sJX/HPqHXQWoXZ8z/zfWzeFnQ12z+Q3Efjk5Yf5Fzuekfy99iryOqc1s/Jqwt+z8/ eufhjfr77S8fqmv9cjVjGbe9EktxRqKhFnNRcSIADeN9rQEDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 826 Lines: 27 Hi Krzysztof, On 04/12/2016 07:35 PM, Krzysztof Kozlowski wrote: > On 04/12/2016 02:49 PM, Alim Akhtar wrote: >> This patch adds device tree nodes for pdma0 and pdma1 controllers >> found on exynos7 SoCs. >> >> Signed-off-by: Alim Akhtar >> --- >> arch/arm64/boot/dts/exynos/exynos7.dtsi | 29 +++++++++++++++++++++++++++++ >> 1 file changed, 29 insertions(+) >> > > I would prefer avoid adding all new stuff at the end because it is > conflict-prone. Alphabetical order or by address... but none of these > are used currently. How about putting it after 'gic' node? > hmm....ok will send v2 with suggested changes. Looks like other platforms also put it below 'gic'. > Anyway the code looks fine: > Reviewed-by: Krzysztof Kozlowski > > Best regards, > Krzysztof > >