Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758841AbcDMFY1 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 13 Apr 2016 01:24:27 -0400
Received: from mail-oi0-f50.google.com ([209.85.218.50]:33214 "EHLO
	mail-oi0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752036AbcDMFY0 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 13 Apr 2016 01:24:26 -0400
MIME-Version: 1.0
In-Reply-To: <1460506252-8596-1-git-send-email-toshi.kani@hpe.com>
References: <1460506252-8596-1-git-send-email-toshi.kani@hpe.com>
Date: Tue, 12 Apr 2016 22:24:25 -0700
Message-ID: <CAPcyv4hDLN1F-A3bsQdBdksFP6hWnpw_KkgWwLC5UcfcmcSr-Q@mail.gmail.com>
Subject: Re: [PATCH] pmem: fix BUG() error in pmem.h:48 on X86_32
From: Dan Williams <dan.j.williams@intel.com>
To: Toshi Kani <toshi.kani@hpe.com>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>,
        "linux-nvdimm@lists.01.org" <linux-nvdimm@ml01.01.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 697
Lines: 18

On Tue, Apr 12, 2016 at 5:10 PM, Toshi Kani <toshi.kani@hpe.com> wrote:
> After 'commit fc0c2028135c ("x86, pmem: use memcpy_mcsafe()
> for memcpy_from_pmem()")', probing a PMEM device hits the BUG()
> error below on X86_32 kernel.
>
>  kernel BUG at include/linux/pmem.h:48!
>
> memcpy_from_pmem() calls arch_memcpy_from_pmem(), which is
> unimplemented since CONFIG_ARCH_HAS_PMEM_API is undefined on
> X86_32.
>
> Fix the BUG() error by adding default_memcpy_from_pmem().
>
> Signed-off-by: Toshi Kani <toshi.kani@hpe.com>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: Ross Zwisler <ross.zwisler@linux.intel.com>

Whoops, I'll add a 32-bit boot test to my release criteria.  Thanks Toshi!