Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S966069AbcDMHJ1 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 13 Apr 2016 03:09:27 -0400
Received: from mga09.intel.com ([134.134.136.24]:45804 "EHLO mga09.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S966028AbcDMHJY (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 13 Apr 2016 03:09:24 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.24,478,1455004800"; 
   d="scan'208";a="957558747"
Date: Wed, 13 Apr 2016 15:07:42 +0800
From: kbuild test robot <fengguang.wu@intel.com>
To: Karol Herbst <nouveau@karolherbst.de>
Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org,
        Ben Skeggs <bskeggs@redhat.com>, Martin Peres <martin.peres@free.fr>,
        David Airlie <airlied@linux.ie>, dri-devel@lists.freedesktop.org
Subject: [PATCH] drm/nouveau/iccsense: fix ifnullfree.cocci warnings
Message-ID: <20160413070742.GA9311@lkp-nex05>
References: <201604131531.CJokPLHc%fengguang.wu@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201604131531.CJokPLHc%fengguang.wu@intel.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-SA-Exim-Connect-IP: <locally generated>
X-SA-Exim-Mail-From: fengguang.wu@intel.com
X-SA-Exim-Scanned: No (on bee); SAEximRunCond expanded to false
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1012
Lines: 29

drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c:133:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.

 NULL check before some freeing functions is not needed.

 Based on checkpatch warning
 "kfree(NULL) is safe this check is probably not required"
 and kfreeaddr.cocci by Julia Lawall.

Generated by: scripts/coccinelle/free/ifnullfree.cocci

CC: Karol Herbst <nouveau@karolherbst.de>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 base.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c
@@ -129,8 +129,7 @@ nvkm_iccsense_dtor(struct nvkm_subdev *s
 {
 	struct nvkm_iccsense *iccsense = nvkm_iccsense(subdev);
 
-	if (iccsense->rails)
-		kfree(iccsense->rails);
+	kfree(iccsense->rails);
 
 	return iccsense;
 }