Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965648AbcDMHzs (ORCPT ); Wed, 13 Apr 2016 03:55:48 -0400 Received: from smtp4-g21.free.fr ([212.27.42.4]:34610 "EHLO smtp4-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932404AbcDMHzr (ORCPT ); Wed, 13 Apr 2016 03:55:47 -0400 Subject: Re: [PATCH] drm/nouveau/iccsense: fix ifnullfree.cocci warnings To: kbuild test robot , Karol Herbst References: <201604131531.CJokPLHc%fengguang.wu@intel.com> <20160413070742.GA9311@lkp-nex05> Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org, Ben Skeggs , David Airlie , dri-devel@lists.freedesktop.org From: Martin Peres Message-ID: <570DFB71.4070106@free.fr> Date: Wed, 13 Apr 2016 10:55:29 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.0 MIME-Version: 1.0 In-Reply-To: <20160413070742.GA9311@lkp-nex05> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 718 Lines: 14 On 13/04/16 10:07, kbuild test robot wrote: > drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c:133:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. > > NULL check before some freeing functions is not needed. > > Based on checkpatch warning > "kfree(NULL) is safe this check is probably not required" > and kfreeaddr.cocci by Julia Lawall. > > Generated by: scripts/coccinelle/free/ifnullfree.cocci > > CC: Karol Herbst > Signed-off-by: Fengguang Wu Signed-off-by: Martin Peres