Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934595AbcDMIoy (ORCPT ); Wed, 13 Apr 2016 04:44:54 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:34693 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932482AbcDMIow (ORCPT ); Wed, 13 Apr 2016 04:44:52 -0400 Date: Wed, 13 Apr 2016 10:44:46 +0200 From: Ingo Molnar To: "Luis R. Rodriguez" Cc: bp@alien8.de, hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com, rusty@rustcorp.com.au, x86@kernel.org, linux-kernel@vger.kernel.org, luto@amacapital.net, boris.ostrovsky@oracle.com, david.vrabel@citrix.com, konrad.wilk@oracle.com, xen-devel@lists.xensource.com, lguest@lists.ozlabs.org, andriy.shevchenko@linux.intel.com, jlee@suse.com, glin@suse.com, matt@codeblueprint.co.uk, andrew.cooper3@citrix.com, rjw@rjwysocki.net, lenb@kernel.org, robert.moore@intel.com, lv.zheng@intel.com, toshi.kani@hp.com, linux-acpi@vger.kernel.org, kozerkov@parallels.com, josh@joshtriplett.org, joro@8bytes.org, tiwai@suse.de Subject: Re: [PATCH v5 07/14] tools/lguest: force disable tboot and apm Message-ID: <20160413084446.GA21471@gmail.com> References: <1460158825-13117-1-git-send-email-mcgrof@kernel.org> <1460159886-13344-1-git-send-email-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1460159886-13344-1-git-send-email-mcgrof@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 727 Lines: 25 * Luis R. Rodriguez wrote: > The paravirt_enabled() check is going away, the area tossed to > the kernel on lguest is not zerored out, so ensure lguest force > disables tboot and apm just in case the kernel file being read might > have this set for whatever reason. > > Signed-off-by: Luis R. Rodriguez > --- > tools/lguest/lguest.c | 6 ++++++ > 1 file changed, 6 insertions(+) Yeah, so the v4 patch was acked by Rusty: Acked-by: Rusty Russell ... but you didn't add his ack to the v5 patch :-( Please don't do this! Also please double check all past replies to make sure no acks got lost. I noticed this one, but there might be more. Thanks, Ingo