Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759126AbcDMIta (ORCPT ); Wed, 13 Apr 2016 04:49:30 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:16547 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756983AbcDMIt1 (ORCPT ); Wed, 13 Apr 2016 04:49:27 -0400 X-IronPort-AV: E=Sophos;i="5.24,479,1454972400"; d="scan'208";a="213840454" Date: Wed, 13 Apr 2016 10:49:21 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Songjun Wu cc: linux-arm-kernel@lists.infradead.org, Mauro Carvalho Chehab , Hans Verkuil , Sudip Mukherjee , Mikhail Ulyanov , Fabien Dessenne , Peter Griffin , Benoit Parrot , Laurent Pinchart , Gerd Hoffmann , =?ISO-8859-15?Q?Richard_R=F6jfors?= , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, kbuild@01.org, g.liakhovetski@gmx.de, nicolas.ferre@atmel.com Subject: [PATCH] atmel-isc: fix compare_const_fl.cocci warnings Message-ID: User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 909 Lines: 26 Move constants to the right of binary operators. Generated by: scripts/coccinelle/misc/compare_const_fl.cocci CC: Songjun Wu Signed-off-by: Fengguang Wu Signed-off-by: Julia Lawall --- Up to you. Seems a tiny bit more readable to me not to have ISC_DCTRL and ISC_DCTRL_IE_IS right together. atmel-isc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/media/platform/atmel/atmel-isc.c +++ b/drivers/media/platform/atmel/atmel-isc.c @@ -639,7 +639,7 @@ static inline void isc_start_dma(struct addr = vb2_dma_contig_plane_dma_addr(&frm->vb.vb2_buf, 0); - regmap_write(regmap, ISC_DCTRL, ISC_DCTRL_IE_IS | dview); + regmap_write(regmap, ISC_DCTRL, dview | ISC_DCTRL_IE_IS); regmap_write(regmap, ISC_DAD0, addr); regmap_update_bits(regmap, ISC_CTRLEN, ISC_CTRLEN_CAPTURE_MASK, ISC_CTRLEN_CAPTURE);