Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S934667AbcDMJYr (ORCPT <rfc822;w@1wt.eu>);
	Wed, 13 Apr 2016 05:24:47 -0400
Received: from nasmtp01.atmel.com ([192.199.1.245]:38557 "EHLO
	nasmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932614AbcDMJYp (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 13 Apr 2016 05:24:45 -0400
Subject: Re: [PATCH] atmel-isc: fix compare_const_fl.cocci warnings
To: Julia Lawall <julia.lawall@lip6.fr>
References: <alpine.DEB.2.10.1604131047460.2969@hadrien>
CC: <linux-arm-kernel@lists.infradead.org>,
        Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
        Hans Verkuil <hverkuil@xs4all.nl>,
        Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
        Mikhail Ulyanov <mikhail.ulyanov@cogentembedded.com>,
        Fabien Dessenne <fabien.dessenne@st.com>,
        Peter Griffin <peter.griffin@linaro.org>,
        Benoit Parrot <bparrot@ti.com>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Gerd Hoffmann <kraxel@redhat.com>,
        =?UTF-8?Q?Richard_R=c3=b6jfors?= <richard@puffinpack.se>,
        <linux-kernel@vger.kernel.org>, <linux-media@vger.kernel.org>,
        <kbuild@01.org>, <g.liakhovetski@gmx.de>, <nicolas.ferre@atmel.com>
From: "Wu, Songjun" <songjun.wu@atmel.com>
Organization: ATMEL
Message-ID: <570E1055.60806@atmel.com>
Date: Wed, 13 Apr 2016 17:24:37 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.10.1604131047460.2969@hadrien>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1040
Lines: 31

Accept.
Thank you for your comments.

On 4/13/2016 16:49, Julia Lawall wrote:
> Move constants to the right of binary operators.
>
> Generated by: scripts/coccinelle/misc/compare_const_fl.cocci
>
> CC: Songjun Wu <songjun.wu@atmel.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
>
> Up to you.  Seems a tiny bit more readable to me not to have ISC_DCTRL and
> ISC_DCTRL_IE_IS right together.
>
>   atmel-isc.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/media/platform/atmel/atmel-isc.c
> +++ b/drivers/media/platform/atmel/atmel-isc.c
> @@ -639,7 +639,7 @@ static inline void isc_start_dma(struct
>
>   	addr = vb2_dma_contig_plane_dma_addr(&frm->vb.vb2_buf, 0);
>
> -	regmap_write(regmap, ISC_DCTRL, ISC_DCTRL_IE_IS | dview);
> +	regmap_write(regmap, ISC_DCTRL, dview | ISC_DCTRL_IE_IS);
>   	regmap_write(regmap, ISC_DAD0, addr);
>   	regmap_update_bits(regmap, ISC_CTRLEN,
>   			   ISC_CTRLEN_CAPTURE_MASK, ISC_CTRLEN_CAPTURE);
>