Subject: Re: [PATCH v6 05/10] irqchip/gic-v3: Prefix all pr_* messages by
 "GICv3: "
To: Julien Grall <julien.grall@arm.com>, kvmarm@lists.cs.columbia.edu
References: <1460388780-914-1-git-send-email-julien.grall@arm.com>
 <1460388780-914-6-git-send-email-julien.grall@arm.com>
Cc: christoffer.dall@linaro.org, marc.zyngier@arm.com, fu.wei@linaro.org,
        kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, wei@redhat.com,
        al.stone@linaro.org, gg@slimlogic.co.uk
From: Hanjun Guo <hanjun.guo@linaro.org>
Message-ID: <570E190C.8020203@linaro.org>
Date: Wed, 13 Apr 2016 18:01:48 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.2
MIME-Version: 1.0
In-Reply-To: <1460388780-914-6-git-send-email-julien.grall@arm.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 977
Lines: 35

On 2016/4/11 23:32, Julien Grall wrote:
> Currently, most of the pr_* messages in the GICv3 driver don't have a
> prefix.  Add one to make clear where the messages come from.
>
> Signed-off-by: Julien Grall <julien.grall@arm.com>
>
> ---
>      Changes in v6:
>          - Patch added
> ---
>   drivers/irqchip/irq-gic-v3.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c
> index 5b7d3c2..6dc6f03 100644
> --- a/drivers/irqchip/irq-gic-v3.c
> +++ b/drivers/irqchip/irq-gic-v3.c
> @@ -15,6 +15,8 @@
>    * along with this program.  If not, see <http://www.gnu.org/licenses/>.
>    */
>
> +#define pr_fmt(fmt)	"GICv3: " fmt

I don't think this patch is needed, as GICv3 and GICv2 will
not be probed at the same time, did I miss something?

Further more, there are prefixes in pr_fmt in this
patch using GIC:, with your patch added, it will print:

GIV3: GIC: .....

which is not a good idea.

Thanks
Hanjun