Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934843AbcDMLCJ (ORCPT ); Wed, 13 Apr 2016 07:02:09 -0400 Received: from ozlabs.org ([103.22.144.67]:45291 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934261AbcDMLCH (ORCPT ); Wed, 13 Apr 2016 07:02:07 -0400 Message-ID: <1460545318.24090.1.camel@ellerman.id.au> Subject: Re: [PATCH] sched/cpuacct: Check for NULL when using task_pt_regs() From: Michael Ellerman To: Ingo Molnar , Srikar Dronamraju Cc: Anton Blanchard , Peter Zijlstra , tglx@linutronix.de, efault@gmx.de, htejun@gmail.com, linux-kernel@vger.kernel.org, tj@kernel.org, torvalds@linux-foundation.org, zhaolei@cn.fujitsu.com, yangds.fnst@cn.fujitsu.com, hpa@zytor.com, Stephen Rothwell , linuxppc-dev@lists.ozlabs.org Date: Wed, 13 Apr 2016 21:01:58 +1000 In-Reply-To: <20160413074319.GA8968@gmail.com> References: <20160404140312.GA28495@linux.vnet.ibm.com> <20160406065436.GB3078@gmail.com> <20160406203219.788ae7cf@kryten> <20160406110803.GI2906@worktop> <20160406215950.04bc3f0b@kryten> <20160406132637.GA2108@linux.vnet.ibm.com> <20160413074319.GA8968@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5-1ubuntu3.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 817 Lines: 30 On Wed, 2016-04-13 at 09:43 +0200, Ingo Molnar wrote: > * Srikar Dronamraju wrote: > > > * Anton Blanchard [2016-04-06 21:59:50]: > > > > > Looks good, and the patch below does fix the oops for me. > > > > > > Anton > > > -- > > > > > > task_pt_regs() can return NULL for kernel threads, so add a check. > > > This fixes an oops at boot on ppc64. > > > > > > Signed-off-by: Anton Blanchard > > > > Works for me too. > > > > Reported-and-Tested-by: Srikar Dronamraju > > Could someone please re-send the fix, because it has not reached me nor lkml. It did hit LKML: http://lkml.kernel.org/r/20160406215950.04bc3f0b@kryten But that did have some verbiage at the top. Anton's also resent it directly To you. cheers