Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030782AbcDML37 (ORCPT ); Wed, 13 Apr 2016 07:29:59 -0400 Received: from terminus.zytor.com ([198.137.202.10]:55486 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030724AbcDML3x (ORCPT ); Wed, 13 Apr 2016 07:29:53 -0400 Date: Wed, 13 Apr 2016 04:28:11 -0700 From: tip-bot for Denys Vlasenko Message-ID: Cc: peterz@infradead.org, akpm@linux-foundation.org, tglx@linutronix.de, mingo@kernel.org, hpa@zytor.com, dvlasenk@redhat.com, linux-kernel@vger.kernel.org, paulmck@linux.vnet.ibm.com, torvalds@linux-foundation.org Reply-To: hpa@zytor.com, dvlasenk@redhat.com, linux-kernel@vger.kernel.org, paulmck@linux.vnet.ibm.com, torvalds@linux-foundation.org, tglx@linutronix.de, akpm@linux-foundation.org, peterz@infradead.org, mingo@kernel.org In-Reply-To: <1460141926-13069-5-git-send-email-dvlasenk@redhat.com> References: <1460141926-13069-5-git-send-email-dvlasenk@redhat.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:locking/core] locking/lockdep: Deinline register_lock_class(), save 2328 bytes Git-Commit-ID: c003ed928962a55eb446e78c544b1d7c4f6cb88a X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1643 Lines: 39 Commit-ID: c003ed928962a55eb446e78c544b1d7c4f6cb88a Gitweb: http://git.kernel.org/tip/c003ed928962a55eb446e78c544b1d7c4f6cb88a Author: Denys Vlasenko AuthorDate: Fri, 8 Apr 2016 20:58:46 +0200 Committer: Ingo Molnar CommitDate: Wed, 13 Apr 2016 10:06:13 +0200 locking/lockdep: Deinline register_lock_class(), save 2328 bytes This function compiles to 1328 bytes of machine code. Three callsites. Registering a new lock class is definitely not *that* time-critical to inline it. Signed-off-by: Denys Vlasenko Cc: Andrew Morton Cc: Linus Torvalds Cc: Paul E. McKenney Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: linux-kernel@vger.kernel.org Link: http://lkml.kernel.org/r/1460141926-13069-5-git-send-email-dvlasenk@redhat.com Signed-off-by: Ingo Molnar --- kernel/locking/lockdep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c index ed94109..7cc43ef 100644 --- a/kernel/locking/lockdep.c +++ b/kernel/locking/lockdep.c @@ -708,7 +708,7 @@ look_up_lock_class(struct lockdep_map *lock, unsigned int subclass) * yet. Otherwise we look it up. We cache the result in the lock object * itself, so actual lookup of the hash should be once per lock object. */ -static inline struct lock_class * +static struct lock_class * register_lock_class(struct lockdep_map *lock, unsigned int subclass, int force) { struct lockdep_subclass_key *key;