Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760153AbcDMMkq (ORCPT ); Wed, 13 Apr 2016 08:40:46 -0400 Received: from mail-lf0-f45.google.com ([209.85.215.45]:35143 "EHLO mail-lf0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750739AbcDMMko (ORCPT ); Wed, 13 Apr 2016 08:40:44 -0400 Date: Wed, 13 Apr 2016 15:40:34 +0300 From: Cyrill Gorcunov To: Florian Weimer , "Richard W.M. Jones" Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, akpm@linux-foundation.org, luto@kernel.org, viro@zeniv.linux.org.uk, mathieu.desnoyers@efficios.com, zab@redhat.com, emunson@akamai.com, paulmck@linux.vnet.ibm.com, aarcange@redhat.com, josh@joshtriplett.org, xemul@parallels.com, sfr@canb.auug.org.au, milosz@adfin.com, rostedt@goodmis.org, arnd@arndb.de, ebiederm@xmission.com, iulia.manda21@gmail.com, dave.hansen@linux.intel.com, mguzik@redhat.com, adobriyan@gmail.com, dave@stgolabs.net, linux-api@vger.kernel.org Subject: Re: [PATCH 1/2] vfs: Define new syscall getumask. Message-ID: <20160413124034.GI2000@uranus.lan> References: <1460547786-16766-1-git-send-email-rjones@redhat.com> <1460547786-16766-2-git-send-email-rjones@redhat.com> <87inzlg0mo.fsf@mid.deneb.enyo.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87inzlg0mo.fsf@mid.deneb.enyo.de> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 290 Lines: 12 On Wed, Apr 13, 2016 at 02:21:35PM +0200, Florian Weimer wrote: > * Richard W. M. Jones: > > > +SYSCALL_DEFINE0(getumask) > > +{ > > + return current->fs->umask; > > +} > > The convention seems to be to call current_umask(), instead of > inlining its contents. Yes, please use existing.