Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760204AbcDMMow (ORCPT ); Wed, 13 Apr 2016 08:44:52 -0400 Received: from albireo.enyo.de ([46.237.207.196]:39254 "EHLO albireo.enyo.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759953AbcDMMou (ORCPT ); Wed, 13 Apr 2016 08:44:50 -0400 X-Greylist: delayed 1381 seconds by postgrey-1.27 at vger.kernel.org; Wed, 13 Apr 2016 08:44:50 EDT From: Florian Weimer To: "Richard W.M. Jones" Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, akpm@linux-foundation.org, luto@kernel.org, viro@zeniv.linux.org.uk, mathieu.desnoyers@efficios.com, zab@redhat.com, emunson@akamai.com, paulmck@linux.vnet.ibm.com, aarcange@redhat.com, josh@joshtriplett.org, xemul@parallels.com, sfr@canb.auug.org.au, milosz@adfin.com, rostedt@goodmis.org, arnd@arndb.de, ebiederm@xmission.com, gorcunov@openvz.org, iulia.manda21@gmail.com, dave.hansen@linux.intel.com, mguzik@redhat.com, adobriyan@gmail.com, dave@stgolabs.net, linux-api@vger.kernel.org Subject: Re: [PATCH 1/2] vfs: Define new syscall getumask. References: <1460547786-16766-1-git-send-email-rjones@redhat.com> <1460547786-16766-2-git-send-email-rjones@redhat.com> Date: Wed, 13 Apr 2016 14:21:35 +0200 In-Reply-To: <1460547786-16766-2-git-send-email-rjones@redhat.com> (Richard W. M. Jones's message of "Wed, 13 Apr 2016 12:43:05 +0100") Message-ID: <87inzlg0mo.fsf@mid.deneb.enyo.de> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 181 Lines: 9 * Richard W. M. Jones: > +SYSCALL_DEFINE0(getumask) > +{ > + return current->fs->umask; > +} The convention seems to be to call current_umask(), instead of inlining its contents.